Issue 2661023005: Isolate the part of AnalysisDriver that manages the AnalysisContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2661023005: Isolate the part of AnalysisDriver that manages the AnalysisContext. (Closed)

Created:
3 years, 10 months ago by Paul Berry

Modified:
3 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Isolate the part of AnalysisDriver that manages the AnalysisContext. I re-used the existing class _LibraryContext, but moved it to its own file and gave it a public API so that the rest of the AnalysisDriver doesn't have to deal with the AnalysisContext directly. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/acf5b16a5f4787e166ec1cbf33b8c565d610aaa6

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+255 lines, -165 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View		7 chunks	+21 lines, -165 lines	0 comments	Download
	A	pkg/analyzer/lib/src/dart/analysis/library_context.dart	View		1 chunk	+234 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 10 months ago (2017-01-31 20:33:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
acf5b16a5f4787e166ec1cbf33b8c565d610aaa6 (presubmit successful).