Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/component_updater/sw_reporter_installer_win.cc

Issue 2660993003: Run software reporter's experimental engine on all architectures (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/sw_reporter_installer_win.cc
diff --git a/chrome/browser/component_updater/sw_reporter_installer_win.cc b/chrome/browser/component_updater/sw_reporter_installer_win.cc
index 8d28b344176f8a2deac9ebd0ae86444024faf79f..c558cfd468619d0e494ba6701a371b3b5ff807cb 100644
--- a/chrome/browser/component_updater/sw_reporter_installer_win.cc
+++ b/chrome/browser/component_updater/sw_reporter_installer_win.cc
@@ -83,6 +83,10 @@ const wchar_t kVersionValueName[] = L"Version";
constexpr base::Feature kExperimentalEngineFeature{
"ExperimentalSwReporterEngine", base::FEATURE_DISABLED_BY_DEFAULT};
+constexpr base::Feature kExperimentalEngineAllArchsFeature{
+ "ExperimentalSwReporterEngineOnAllArchitectures",
+ base::FEATURE_DISABLED_BY_DEFAULT
+};
void SRTHasCompleted(SRTCompleted value) {
UMA_HISTOGRAM_ENUMERATION("SoftwareReporter.Cleaner.HasCompleted", value,
@@ -475,11 +479,15 @@ void RegisterSwReporterComponent(ComponentUpdateService* cus) {
}
}
- // The experiment is only enabled on x86. There's no way to check this in the
+ // If the experiment is not explicitly enabled on all platforms, it
+ // should be only enabled on x86. There's no way to check this in the
// variations config so we'll hard-code it.
- const bool is_experimental_engine_supported =
+ const bool is_x86_architecture =
base::win::OSInfo::GetInstance()->architecture() ==
base::win::OSInfo::X86_ARCHITECTURE;
+ const bool is_experimental_engine_supported =
+ base::FeatureList::IsEnabled(kExperimentalEngineAllArchsFeature) ||
+ is_x86_architecture;
// Install the component.
std::unique_ptr<ComponentInstallerTraits> traits(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698