[wasm] include JS conformance tests in Wasm mjsunit tests

test/mjsunit/wasm/jsapi.js

+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be

[Mircea Trofin, 2017/01/31 02:07:31]

could you rename this to something like jsapi-harness.js?

also, please delete the js-api.js file we've had here, as it becomes obsoleted
by the official one - perhaps after one last look to make sure folks haven't
introduced something new since mid last week, when I did that and pushed to the
git repo our changes.

[titzer, 2017/01/31 05:00:12]

No, please don't delete tests, even if they are redundant with spec tests. It's
faster development to be able to run them independently. If they diverge, we
should correct them.

[Eric Holk, 2017/01/31 17:30:21]

I renamed jsapi.js to jsapi-harness.js, but per Ben's request, I left the ols
js-api.js.

+// found in the LICENSE file.
+
+let failures = [];
+
+let last_promise = new Promise((resolve, reject) => { resolve(); });
+
+function test(func, description) {
+  let maybeErr;
+  try { func(); }
+  catch(e) { maybeErr = e; }
+  if (typeof maybeErr !== 'undefined') {
+    print(`${description}: FAIL. ${maybeErr}`);
+    failures.push(description);
+  } else {
+    print(`${description}: PASS.`);
+  }
+}
+
+function promise_test(func, description) {
+  last_promise = last_promise.then(func)
+  .then(_ => { print(`${description}: PASS.`); })
+  .catch(err => {
+    print(`${description}: FAIL. ${err}`);
+    failures.push(description);
+  });
+}
+
+let assert_equals = assertEquals;
+let assert_true = assertEquals.bind(null, true);
+let assert_false = assertEquals.bind(null, false);

[Mircea Trofin, 2017/01/31 02:07:31]

Could you add a mechanic to whitelist failing tests? Something like a pair
{test_id: <number>, bug_url: "https://crbug.com/<blah>}.

We'd want that encoded outside the git file, since that's shared.

...but that also may mean we need a stable test ID - which may not be terrible
(makes communication with partners easy: test1241 fails on your platform)

[Eric Holk, 2017/01/31 17:30:21]

I added known_failures, keyed on the test description. This isn't quite a good
enough test id, since we have a bunch of tests called "unexpected success in
assertInstantiateError".

As far as a proper test ID, I think this is better addressed in the spec repo,
so I opened https://github.com/WebAssembly/spec/issues/415.

+
+function assert_unreached(description) {
+  throw new Error(`unreachable:\n${description}`);
+}
+
+function assertErrorMessage(f, ctor, test) {
+  try { f(); }
+  catch (e) {
+    assert_true(e instanceof ctor, "expected exception " + ctor.name + ", got " + e);
+    return;
+  }
+  assert_true(false, "expected exception " + ctor.name + ", no exception thrown");
+};
+
+load("test/wasm-js/test/lib/wasm-constants.js");
+load("test/wasm-js/test/lib/wasm-module-builder.js");
+load("test/wasm-js/test/js-api/jsapi.js");
+
+last_promise.then(_ => {
+  if (failures.length > 0) {
+    print("Some tests FAILED:");
+    for (let i in failures) {
+      print(`  ${failures[i]}`);
+    }
+    quit(1);
+  }
+});