Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

Issue 2660893002: DevTools: migrate ResourcesPanel icons over to UI.Icon (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js b/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
index b32588bfc35d12c21b9acd67704fa02f180d61d7..825e66bc8a6a3ea9396ec983fe3bdf669c98df9f 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
@@ -611,8 +611,6 @@ UI.TreeElement = class {
}
this._listItemNode.removeChildren();
- if (this._iconElement)
- this._listItemNode.appendChild(this._iconElement);
if (this._leadingIconsElement)
this._listItemNode.appendChild(this._leadingIconsElement);
this._listItemNode.appendChild(this._titleElement);
@@ -640,14 +638,6 @@ UI.TreeElement = class {
this.treeOutline._shadowRoot.getSelection().setBaseAndExtent(this._titleElement, 0, this._titleElement, 1);
}
- createIcon() {
dgozman 2017/01/30 16:47:52 Nice!
- if (!this._iconElement) {
- this._iconElement = createElementWithClass('div', 'icon');
- this._listItemNode.insertBefore(this._iconElement, this._listItemNode.firstChild);
- this._ensureSelection();
- }
- }
-
/**
* @param {!Array<!UI.Icon>} icons
*/

Powered by Google App Engine
This is Rietveld 408576698