Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Side by Side Diff: components/doodle/doodle_fetcher.h

Issue 2660883002: Introduce a Doodle Fetcher for NTP (Closed)
Patch Set: Tests for URL and TTL. Stubs/Fakes instead nullptr. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_DOODLE_DOODLE_FETCHER_H_
6 #define COMPONENTS_DOODLE_DOODLE_FETCHER_H_
7
8 #include <memory>
9 #include <string>
10 #include <utility>
11 #include <vector>
12
13 #include "base/callback.h"
14 #include "base/macros.h"
15 #include "base/memory/weak_ptr.h"
16 #include "base/optional.h"
17 #include "net/url_request/url_fetcher_delegate.h"
18 #include "url/gurl.h"
19
20 class GoogleURLTracker;
21
22 namespace base {
23 class Clock;
24 class DictionaryValue;
25 class Value;
26 }
27
28 namespace net {
29 class URLRequestContextGetter;
30 }
31
32 namespace doodle {
33
34 enum class DoodleState {
35 AVAILABLE,
36 NO_DOODLE,
37 DOWNLOAD_ERROR,
38 PARSING_ERROR,
39 };
40
41 enum class DoodleType {
42 UNKNOWN,
43 SIMPLE,
44 RANDOM,
45 VIDEO,
46 INTERACTIVE,
47 INLINE_INTERACTIVE,
48 SLIDESHOW,
49 };
50
51 // Information about a Doodle image. If the image is invalid, the |url| will be
52 // empty and invalid. By default the dimensions are 0.
53 struct DoodleImage {
54 DoodleImage();
55 explicit DoodleImage(GURL url);
56 ~DoodleImage();
57
58 GURL url;
59 int height;
60 int width;
61 bool is_animated_gif;
62 bool is_cta;
63
64 // Copying and assignment allowed.
65 };
66
67 // All information about a current doodle that can be fetched from the remote
68 // end. By default, all URLs are empty and therefore invalid.
69 struct DoodleConfig {
70 DoodleConfig();
71 DoodleConfig(const DoodleConfig& config); // = default;
72 ~DoodleConfig();
73
74 DoodleType doodle_type;
75 std::string alt_text;
76 std::string interactive_html;
77
78 base::Time expiry_date;
79 GURL search_url;
80 GURL target_url;
81 GURL fullpage_interactive_url;
82
83 DoodleImage large_image;
84 DoodleImage large_cta_image;
85 DoodleImage transparent_large_image;
86 };
87
88 // This class provides information about any recent doodle.
89 // It works asynchronously and calls a callback when finished fetching the
90 // information from the remote enpoint.
91 class DoodleFetcher : public net::URLFetcherDelegate {
92 public:
93 // Callback that is invoked when the fetching is done.
94 // |doodle_config| will only contain a value if |state| is AVAILABLE.
95 using FinishedCallback = base::OnceCallback<void(
96 DoodleState state,
97 const base::Optional<DoodleConfig>& doodle_config)>;
98 using ParseJSONCallback = base::Callback<void(
99 const std::string& unsafe_json,
100 const base::Callback<void(std::unique_ptr<base::Value> json)>& success,
101 const base::Callback<void(const std::string&)>& error)>;
102
103 DoodleFetcher(net::URLRequestContextGetter* download_context,
104 GoogleURLTracker* google_url_tracker,
105 const ParseJSONCallback& json_parsing_callback);
106 DoodleFetcher(DoodleFetcher&&);
107 ~DoodleFetcher() override;
108
109 // Fetches a doodle asynchronously. The |callback| is always called and
110 // provides a valid DoodleConfig object.
111 // If a fetch is already running, the callback will be queued and invoked with
112 // result from the next completed request.
113 void FetchDoodle(FinishedCallback callback);
114
115 // Overrides internal clock for testing purposes.
116 void SetClockForTesting(std::unique_ptr<base::Clock> clock) {
117 clock_ = std::move(clock);
118 }
119
120 private:
121 // net::URLFetcherDelegate implementation.
122 void OnURLFetchComplete(const net::URLFetcher* source) override;
123
124 // ParseJSONCallback Success callback
125 void OnJsonParsed(std::unique_ptr<base::Value> json);
126 // ParseJSONCallback Failure callback
127 void OnJsonParseFailed(const std::string& error_message);
128
129 void ParseDoodle(std::unique_ptr<base::DictionaryValue> config);
130 bool ParseImage(const base::DictionaryValue& image_dict,
131 const std::string& image_name,
132 DoodleImage* image) const;
133 void ParseBaseInformation(const base::DictionaryValue& ddljson,
134 DoodleConfig* config) const;
135 GURL ParseRelativeUrl(const base::DictionaryValue& dict_value,
136 const std::string& key) const;
137
138 void RespondToAllCallbacks(DoodleState state,
139 const base::Optional<DoodleConfig>& config);
140 GURL GetGoogleBaseUrl() const;
141
142 // Parameters set from constructor.
143 net::URLRequestContextGetter* const download_context_;
144 ParseJSONCallback json_parsing_callback_;
145 GoogleURLTracker* google_url_tracker_;
146
147 // Allow for an injectable tick clock for testing.
148 std::unique_ptr<base::Clock> clock_;
149
150 std::vector<FinishedCallback> callbacks_;
151 std::unique_ptr<net::URLFetcher> fetcher_;
152
153 base::WeakPtrFactory<DoodleFetcher> weak_ptr_factory_;
154
155 DISALLOW_COPY_AND_ASSIGN(DoodleFetcher);
156 };
157
158 } // namespace doodle
159
160 #endif // COMPONENTS_DOODLE_DOODLE_FETCHER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698