Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: ash/shell/panel_window.cc

Issue 2660873002: Move two utility functions from ash/screen_util.h to ui/wm/core/coordinate_conversion.h (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/screen_util_unittest.cc ('k') | ash/wm/drag_window_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shell/panel_window.h" 5 #include "ash/shell/panel_window.h"
6 6
7 #include "ash/common/wm/panels/panel_frame_view.h" 7 #include "ash/common/wm/panels/panel_frame_view.h"
8 #include "ash/public/cpp/window_properties.h" 8 #include "ash/public/cpp/window_properties.h"
9 #include "ash/screen_util.h"
10 #include "ash/shell.h" 9 #include "ash/shell.h"
11 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
12 #include "ui/aura/window.h" 11 #include "ui/aura/window.h"
13 #include "ui/gfx/canvas.h" 12 #include "ui/gfx/canvas.h"
14 #include "ui/views/widget/widget.h" 13 #include "ui/views/widget/widget.h"
14 #include "ui/wm/core/coordinate_conversion.h"
15 15
16 namespace { 16 namespace {
17 const int kMinWidth = 100; 17 const int kMinWidth = 100;
18 const int kMinHeight = 100; 18 const int kMinHeight = 100;
19 const int kDefaultWidth = 200; 19 const int kDefaultWidth = 200;
20 const int kDefaultHeight = 300; 20 const int kDefaultHeight = 300;
21 } 21 }
22 22
23 namespace ash { 23 namespace ash {
24 24
(...skipping 12 matching lines...) Expand all
37 37
38 PanelWindow::~PanelWindow() {} 38 PanelWindow::~PanelWindow() {}
39 39
40 views::Widget* PanelWindow::CreateWidget() { 40 views::Widget* PanelWindow::CreateWidget() {
41 views::Widget* widget = new views::Widget; 41 views::Widget* widget = new views::Widget;
42 42
43 if (params().bounds.width() == 0) 43 if (params().bounds.width() == 0)
44 params().bounds.set_width(kDefaultWidth); 44 params().bounds.set_width(kDefaultWidth);
45 if (params().bounds.height() == 0) 45 if (params().bounds.height() == 0)
46 params().bounds.set_height(kDefaultHeight); 46 params().bounds.set_height(kDefaultHeight);
47 params().bounds = ScreenUtil::ConvertRectToScreen( 47 ::wm::ConvertRectToScreen(Shell::GetTargetRootWindow(), &params().bounds);
48 Shell::GetTargetRootWindow(), params().bounds);
49 48
50 widget->Init(params()); 49 widget->Init(params());
51 widget->GetNativeView()->SetName(name_); 50 widget->GetNativeView()->SetName(name_);
52 widget->GetNativeWindow()->SetProperty<int>(kShelfItemTypeKey, 51 widget->GetNativeWindow()->SetProperty<int>(kShelfItemTypeKey,
53 TYPE_APP_PANEL); 52 TYPE_APP_PANEL);
54 widget->Show(); 53 widget->Show();
55 54
56 return widget; 55 return widget;
57 } 56 }
58 57
(...skipping 20 matching lines...) Expand all
79 bool PanelWindow::CanMinimize() const { 78 bool PanelWindow::CanMinimize() const {
80 return false; 79 return false;
81 } 80 }
82 81
83 views::NonClientFrameView* PanelWindow::CreateNonClientFrameView( 82 views::NonClientFrameView* PanelWindow::CreateNonClientFrameView(
84 views::Widget* widget) { 83 views::Widget* widget) {
85 return new PanelFrameView(widget, PanelFrameView::FRAME_NONE); 84 return new PanelFrameView(widget, PanelFrameView::FRAME_NONE);
86 } 85 }
87 86
88 } // namespace ash 87 } // namespace ash
OLDNEW
« no previous file with comments | « ash/screen_util_unittest.cc ('k') | ash/wm/drag_window_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698