Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1547)

Unified Diff: tools/push-to-trunk/common_includes.py

Issue 266083003: Remove old branch logic from push scripts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix logging subprocesses. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/push-to-trunk/merge_to_branch.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/push-to-trunk/common_includes.py
diff --git a/tools/push-to-trunk/common_includes.py b/tools/push-to-trunk/common_includes.py
index aaa25cfa79389e68a8563b62fa873c804e03b211..482509f7d1974e9fbf946c6995be33caae920e76 100644
--- a/tools/push-to-trunk/common_includes.py
+++ b/tools/push-to-trunk/common_includes.py
@@ -42,7 +42,6 @@ from git_recipes import GitRecipesMixin
from git_recipes import GitFailedException
PERSISTFILE_BASENAME = "PERSISTFILE_BASENAME"
-TEMP_BRANCH = "TEMP_BRANCH"
BRANCHNAME = "BRANCHNAME"
DOT_GIT_LOCATION = "DOT_GIT_LOCATION"
VERSION_FILE = "VERSION_FILE"
@@ -176,6 +175,7 @@ def Command(cmd, args="", prefix="", pipe=True):
# TODO(machenbach): Use timeout.
cmd_line = "%s %s %s" % (prefix, cmd, args)
print "Command: %s" % cmd_line
+ sys.stdout.flush()
try:
if pipe:
return subprocess.check_output(cmd_line, shell=True)
@@ -183,6 +183,9 @@ def Command(cmd, args="", prefix="", pipe=True):
return subprocess.check_call(cmd_line, shell=True)
except subprocess.CalledProcessError:
return None
+ finally:
+ sys.stdout.flush()
+ sys.stderr.flush()
# Wrapper for side effects.
@@ -376,18 +379,11 @@ class Step(GitRecipesMixin):
self.GitSVNFetch()
def PrepareBranch(self):
- # Get ahold of a safe temporary branch and check it out.
- if self["current_branch"] != self._config[TEMP_BRANCH]:
- self.DeleteBranch(self._config[TEMP_BRANCH])
- self.GitCreateBranch(self._config[TEMP_BRANCH])
-
# Delete the branch that will be created later if it exists already.
self.DeleteBranch(self._config[BRANCHNAME])
def CommonCleanup(self):
self.GitCheckout(self["current_branch"])
- if self._config[TEMP_BRANCH] != self["current_branch"]:
- self.GitDeleteBranch(self._config[TEMP_BRANCH])
if self._config[BRANCHNAME] != self["current_branch"]:
self.GitDeleteBranch(self._config[BRANCHNAME])
« no previous file with comments | « no previous file | tools/push-to-trunk/merge_to_branch.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698