Issue 266083003: Remove old branch logic from push scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266083003: Remove old branch logic from push scripts. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach

Modified:
6 years, 7 months ago

Reviewers:
Jarin

CC:
v8-dev, Jakob Kummerow

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove old branch logic from push scripts. The old temporary branch is not needed anymore. All scripts create a different branch after creating the temporary branch. This also fixes logging subprocesses and logs a warning to track down script failures due to wrong branches. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21147

Patch Set 1 #

Patch Set 2 : Fix logging subprocesses. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -28 lines)			Patch
M	tools/push-to-trunk/common_includes.py	View	1	4 chunks	+4 lines, -8 lines	0 comments	Download
M	tools/push-to-trunk/merge_to_branch.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	tools/push-to-trunk/releases.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View		10 chunks	+5 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

6 years, 7 months ago (2014-05-05 15:16:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21147 (presubmit successful).

Expand Messages | Collapse Messages