Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2947)

Unified Diff: chrome/browser/ui/test/test_browser_dialog.h

Issue 2660813002: Add WidgetTest::GetAllWidgets() to find dialogs created by TestBrowserDialog. (Closed)
Patch Set: respond to comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/test/test_browser_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/test/test_browser_dialog.h
diff --git a/chrome/browser/ui/test/test_browser_dialog.h b/chrome/browser/ui/test/test_browser_dialog.h
index 9eeac318c12039b751643180ad31a541969ce208..d071a805bbf71f8f68c285c502a04583cfb399b3 100644
--- a/chrome/browser/ui/test/test_browser_dialog.h
+++ b/chrome/browser/ui/test/test_browser_dialog.h
@@ -9,7 +9,6 @@
#include <vector>
#include "base/macros.h"
-#include "chrome/browser/ui/browser_window.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/native_widget_types.h"
@@ -65,9 +64,6 @@ class TestBrowserDialog {
// Show the dialog corresponding to |name| and leave it open.
virtual void ShowDialog(const std::string& name) = 0;
- // The window that owns the dialogs. Used to find where the dialog appears.
- virtual gfx::NativeWindow DialogParent() = 0;
-
private:
DISALLOW_COPY_AND_ASSIGN(TestBrowserDialog);
};
@@ -79,11 +75,6 @@ class SupportsTestDialog : public Base, public TestBrowserDialog {
protected:
SupportsTestDialog() {}
- // TestBrowserDialog:
- gfx::NativeWindow DialogParent() override {
- return this->browser()->window()->GetNativeWindow();
- }
-
private:
DISALLOW_COPY_AND_ASSIGN(SupportsTestDialog);
};
« no previous file with comments | « no previous file | chrome/browser/ui/test/test_browser_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698