Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: net/tools/transport_security_state_generator/input_file_parsers.cc

Issue 2660793002: Add transport security state generator tests. (Closed)
Patch Set: export method for tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/transport_security_state_generator/input_file_parsers.cc
diff --git a/net/tools/transport_security_state_generator/input_file_parsers.cc b/net/tools/transport_security_state_generator/input_file_parsers.cc
new file mode 100644
index 0000000000000000000000000000000000000000..cb65ec283dc33215139105b58630016cac04009d
--- /dev/null
+++ b/net/tools/transport_security_state_generator/input_file_parsers.cc
@@ -0,0 +1,401 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/tools/transport_security_state_generator/input_file_parsers.h"
+
+#include <sstream>
+#include <vector>
+
+#include "base/json/json_reader.h"
+#include "base/strings/string_piece.h"
+#include "base/strings/string_split.h"
+#include "base/strings/string_util.h"
+#include "base/values.h"
+#include "net/tools/transport_security_state_generator/cert_util.h"
+#include "net/tools/transport_security_state_generator/pinset.h"
+#include "net/tools/transport_security_state_generator/pinsets.h"
+#include "net/tools/transport_security_state_generator/spki_hash.h"
+#include "third_party/boringssl/src/include/openssl/x509v3.h"
+
+namespace net {
+
+namespace transport_security_state {
+
+namespace {
+
+std::string ToString(size_t number) {
+ std::stringstream s;
+ s << number;
+ return s.str();
+}
+
+bool IsImportantWordInCertificateName(base::StringPiece name) {
+ const char* const important_words[] = {"Universal", "Global", "EV", "G1",
+ "G2", "G3", "G4", "G5"};
+ for (auto* important_word : important_words) {
+ if (name == important_word) {
+ return true;
+ }
+ }
+ return false;
+}
+
+// Strips all characters not matched by the RegEx [A-Za-z0-9_] from |name| and
+// returns the result.
+std::string FilterName(base::StringPiece name) {
+ std::string filtered;
+ for (const char& character : name) {
+ if ((character >= '0' && character <= '9') ||
+ (character >= 'a' && character <= 'z') ||
+ (character >= 'A' && character <= 'Z') || character == '_') {
+ filtered += character;
+ }
+ }
+ return base::ToLowerASCII(filtered);
+}
+
+// Returns true if |pin_name| is a reasonable match for the certificate name
+// |name|.
+bool MatchCertificateName(base::StringPiece name,
+ base::StringPiece pin_name,
+ std::vector<std::string>* errors) {
+ std::vector<base::StringPiece> words = base::SplitStringPiece(
+ name, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ if (words.empty()) {
+ errors->push_back("No words in certificate name for pin (" +
+ pin_name.as_string() + ")");
+ return false;
+ }
+ base::StringPiece first_word = words[0];
+
+ if (first_word.ends_with(",")) {
+ first_word = first_word.substr(0, first_word.size() - 1);
+ }
+
+ if (first_word.starts_with("*.")) {
+ first_word = first_word.substr(2, first_word.size() - 2);
+ }
+
+ size_t pos = first_word.find('.');
+ if (pos != std::string::npos) {
+ first_word = first_word.substr(0, first_word.size() - pos);
+ }
+
+ pos = first_word.find('-');
+ if (pos != std::string::npos) {
+ first_word = first_word.substr(0, first_word.size() - pos);
+ }
+
+ if (first_word.empty()) {
+ errors->push_back("First word of certificate name (" + name.as_string() +
+ ") is empty");
+ return false;
+ }
+
+ std::string filtered_word = FilterName(first_word);
+ first_word = filtered_word;
+ if (!base::EqualsCaseInsensitiveASCII(pin_name.substr(0, first_word.size()),
+ first_word)) {
+ errors->push_back(
+ "The first word of the certificate name (" + first_word.as_string() +
+ ") isn't a prefix of the variable name (" + pin_name.as_string() + ")");
+ return false;
+ }
+
+ for (size_t i = 0; i < words.size(); ++i) {
+ const base::StringPiece& word = words[i];
+ if (word == "Class" && (i + 1) < words.size()) {
+ std::string class_name = word.as_string();
+ words[i + 1].AppendToString(&class_name);
+
+ size_t pos = pin_name.find(class_name);
+ if (pos == std::string::npos) {
+ errors->push_back(
+ "Class specification doesn't appear in the variable name (" +
+ pin_name.as_string() + ")");
+ return false;
+ }
+ } else if (word.size() == 1 && word[0] >= '0' && word[0] <= '9') {
+ size_t pos = pin_name.find(word);
+ if (pos == std::string::npos) {
+ errors->push_back("Number doesn't appear in the variable name (" +
+ pin_name.as_string() + ")");
+ return false;
+ }
+ } else if (IsImportantWordInCertificateName(word)) {
+ size_t pos = pin_name.find(word);
+ if (pos == std::string::npos) {
+ errors->push_back(word.as_string() +
+ " doesn't appear in the variable name (" +
+ pin_name.as_string() + ")");
+ return false;
+ }
+ }
+ }
+
+ return true;
+}
+
+// Returns true iff |candidate| is not empty, the first character is in the
+// range A-Z, and the remaining characters are in the ranges a-Z, 0-9, or '_'.
+bool IsValidName(const std::string& candidate) {
+ if (candidate.empty() || candidate[0] < 'A' || candidate[0] > 'Z') {
+ return false;
+ }
+
+ bool isValid = true;
+ for (const char& character : candidate) {
+ isValid = (character >= '0' && character <= '9') ||
+ (character >= 'a' && character <= 'z') ||
+ (character >= 'A' && character <= 'Z') || character == '_';
+ if (!isValid) {
+ return false;
+ }
+ }
+ return true;
+}
+
+static const char kStartOfCert[] = "-----BEGIN CERTIFICATE";
+static const char kStartOfPublicKey[] = "-----BEGIN PUBLIC KEY";
+static const char kEndOfCert[] = "-----END CERTIFICATE";
+static const char kEndOfPublicKey[] = "-----END PUBLIC KEY";
+static const char kStartOfSHA256[] = "sha256/";
+
+enum class CertificateParserState {
+ PRE_NAME,
+ POST_NAME,
+ IN_CERTIFICATE,
+ IN_PUBLIC_KEY
+};
+
+} // namespace
+
+bool ParseJSON(const std::string& json,
+ TransportSecurityStateEntries* entries,
+ Pinsets* pinsets,
+ DomainIDList* domain_ids,
+ std::vector<std::string>* errors) {
+ DCHECK(errors);
+ std::unique_ptr<base::Value> value = base::JSONReader::Read(json);
+ base::DictionaryValue* dict_value = nullptr;
+ if (!value.get() || !value->GetAsDictionary(&dict_value)) {
+ errors->push_back("Could not parse the input JSON file");
+ return false;
+ }
+
+ const base::ListValue* preload_entries = nullptr;
+ if (!dict_value->GetList("entries", &preload_entries)) {
+ errors->push_back("Could not parse the entries in the input JSON");
+ return false;
+ }
+
+ for (size_t i = 0; i < preload_entries->GetSize(); ++i) {
+ const base::DictionaryValue* parsed = nullptr;
+ if (!preload_entries->GetDictionary(i, &parsed)) {
+ errors->push_back("Could not parse entry " + ToString(i) +
+ " in the input JSON");
+ return false;
+ }
+
+ std::unique_ptr<TransportSecurityStateEntry> entry(
+ new TransportSecurityStateEntry());
+
+ if (!parsed->GetString("name", &entry->hostname)) {
+ errors->push_back("Could not extract the hostname for entry " +
+ ToString(i) + " from the input JSON");
+ return false;
+ }
+
+ parsed->GetBoolean("include_subdomains", &entry->include_subdomains);
+ std::string mode;
+ parsed->GetString("mode", &mode);
+ entry->force_https = (mode == "force-https");
+ parsed->GetBoolean("include_subdomains_for_pinning",
+ &entry->hpkp_include_subdomains);
+ parsed->GetString("pins", &entry->pinset);
+ parsed->GetBoolean("expect_ct", &entry->expect_ct);
+ parsed->GetString("expect_ct_report_uri", &entry->expect_ct_report_uri);
+ parsed->GetBoolean("expect_staple", &entry->expect_staple);
+ parsed->GetBoolean("include_subdomains_for_expect_staple",
+ &entry->expect_staple_include_subdomains);
+ parsed->GetString("expect_staple_report_uri",
+ &entry->expect_staple_report_uri);
+
+ entries->push_back(std::move(entry));
+ }
+
+ const base::ListValue* pinsets_list = nullptr;
+ if (!dict_value->GetList("pinsets", &pinsets_list)) {
+ errors->push_back("Could not parse the pinsets in the input JSON");
+ return false;
+ }
+
+ for (size_t i = 0; i < pinsets_list->GetSize(); ++i) {
+ const base::DictionaryValue* parsed = nullptr;
+ if (!pinsets_list->GetDictionary(i, &parsed)) {
+ errors->push_back("Could not parse pinset " + ToString(i) +
+ " in the input JSON");
+ return false;
+ }
+
+ std::string name;
+ if (!parsed->GetString("name", &name)) {
+ errors->push_back("Could not extract the name for pinset " + ToString(i) +
+ " from the input JSON");
+ return false;
+ }
+
+ std::string report_uri;
+ parsed->GetString("report_uri", &report_uri);
+
+ std::unique_ptr<Pinset> pinset(new Pinset(name, report_uri));
+
+ const base::ListValue* pinset_static_hashes_list = nullptr;
+ if (parsed->GetList("static_spki_hashes", &pinset_static_hashes_list)) {
+ for (size_t i = 0; i < pinset_static_hashes_list->GetSize(); ++i) {
+ std::string hash;
+ pinset_static_hashes_list->GetString(i, &hash);
+ pinset->AddStaticSPKIHash(hash);
+ }
+ }
+
+ const base::ListValue* pinset_bad_static_hashes_list = nullptr;
+ if (parsed->GetList("bad_static_spki_hashes",
+ &pinset_bad_static_hashes_list)) {
+ for (size_t i = 0; i < pinset_bad_static_hashes_list->GetSize(); ++i) {
+ std::string hash;
+ pinset_bad_static_hashes_list->GetString(i, &hash);
+ pinset->AddBadStaticSPKIHash(hash);
+ }
+ }
+
+ pinsets->RegisterPinset(std::move(pinset));
+ }
+
+ // TODO(Martijnc): Remove the domain IDs from the preload format.
+ // https://crbug.com/661206.
+ const base::ListValue* domain_ids_list = nullptr;
+ if (!dict_value->GetList("domain_ids", &domain_ids_list)) {
+ errors->push_back("Could not parse the domain IDs in the input JSON");
+ return false;
+ }
+
+ for (size_t i = 0; i < domain_ids_list->GetSize(); ++i) {
+ std::string domain;
+ domain_ids_list->GetString(i, &domain);
+ domain_ids->push_back(domain);
+ }
+
+ return true;
+}
+
+bool ParseCertificatesFile(const std::string& certs_input,
+ Pinsets* pinsets,
+ std::vector<std::string>* errors) {
+ std::istringstream input_stream(certs_input);
+ std::string line;
+ CertificateParserState current_state = CertificateParserState::PRE_NAME;
+
+ const base::CompareCase& compare_mode = base::CompareCase::INSENSITIVE_ASCII;
+ std::string name;
+ std::string buffer;
+ std::string subject_name;
+ bssl::UniquePtr<X509> certificate;
+ SPKIHash hash;
+
+ for (std::string line; std::getline(input_stream, line);) {
+ if (line[0] == '#') {
+ continue;
+ }
+
+ if (line.empty() && current_state == CertificateParserState::PRE_NAME) {
+ continue;
+ }
+
+ switch (current_state) {
+ case CertificateParserState::PRE_NAME:
+ if (!IsValidName(line)) {
+ errors->push_back("Invalid name in pins file: " + line);
+ return false;
+ }
+ name = line;
+ current_state = CertificateParserState::POST_NAME;
+ break;
+ case CertificateParserState::POST_NAME:
+ if (base::StartsWith(line, kStartOfSHA256, compare_mode)) {
+ if (!hash.FromString(line)) {
+ errors->push_back("Invalid hash value in pins file for " + name);
+ return false;
+ }
+
+ pinsets->RegisterSPKIHash(name, hash);
+ current_state = CertificateParserState::PRE_NAME;
+ } else if (base::StartsWith(line, kStartOfCert, compare_mode)) {
+ buffer = line + '\n';
+ current_state = CertificateParserState::IN_CERTIFICATE;
+ } else if (base::StartsWith(line, kStartOfPublicKey, compare_mode)) {
+ buffer = line + '\n';
+ current_state = CertificateParserState::IN_PUBLIC_KEY;
+ } else {
+ errors->push_back("Invalid value in pins file for " + name);
+ return false;
+ }
+ break;
+ case CertificateParserState::IN_CERTIFICATE:
+ buffer += line + '\n';
+ if (!base::StartsWith(line, kEndOfCert, compare_mode)) {
+ continue;
+ }
+
+ certificate = GetX509CertificateFromPEM(buffer);
+ if (!certificate) {
+ errors->push_back("Could not parse certificate " + name);
+ return false;
+ }
+
+ if (!CalculateSPKIHashFromCertificate(certificate.get(), &hash)) {
+ errors->push_back("Could not extract SPKI from certificate " + name);
+ return false;
+ }
+
+ if (!ExtractSubjectNameFromCertificate(certificate.get(),
+ &subject_name)) {
+ errors->push_back("Could not extract name from certificate " + name);
+ return false;
+ }
+
+ if (!MatchCertificateName(subject_name, name, errors)) {
+ errors->push_back(name + " is not a reasonable name for " +
+ subject_name);
+ return false;
+ }
+
+ pinsets->RegisterSPKIHash(name, hash);
+ current_state = CertificateParserState::PRE_NAME;
+ break;
+ case CertificateParserState::IN_PUBLIC_KEY:
+ buffer += line + '\n';
+ if (!base::StartsWith(line, kEndOfPublicKey, compare_mode)) {
+ continue;
+ }
+
+ if (!CalculateSPKIHashFromKey(buffer, &hash)) {
+ errors->push_back("Parsing of the public key " + name + " failed");
+ return false;
+ }
+
+ pinsets->RegisterSPKIHash(name, hash);
+ current_state = CertificateParserState::PRE_NAME;
+ break;
+ default:
+ DCHECK(false) << "Unknown parser state";
+ }
+ }
+
+ return true;
+}
+
+} // namespace transport_security_state
+
+} // namespace net

Powered by Google App Engine
This is Rietveld 408576698