Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: net/tools/transport_security_state_generator/bit_writer.h

Issue 2660793002: Add transport security state generator tests. (Closed)
Patch Set: export method for tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/transport_security_state_generator/bit_writer.h
diff --git a/net/tools/transport_security_state_generator/bit_writer.h b/net/tools/transport_security_state_generator/bit_writer.h
index e45ff427dac4fc6fd3df4451b143ba118e1a3249..5ceb846caf46b359d8273662eae13178132622e2 100644
--- a/net/tools/transport_security_state_generator/bit_writer.h
+++ b/net/tools/transport_security_state_generator/bit_writer.h
@@ -9,6 +9,8 @@
#include <vector>
+#include "base/macros.h"
+
namespace net {
namespace transport_security_state {
@@ -39,9 +41,6 @@ class BitWriter {
const std::vector<uint8_t>& bytes() const { return bytes_; }
private:
- // Returns the minimum number of bits needed to represent |input|.
martijnc 2017/02/08 20:58:21 This wasn't used.
- uint8_t BitLength(uint32_t input) const;
-
// Buffers bits until they fill a whole byte.
uint8_t current_byte_ = 0;
@@ -52,6 +51,8 @@ class BitWriter {
uint32_t position_ = 0;
std::vector<uint8_t> bytes_;
+
+ DISALLOW_COPY_AND_ASSIGN(BitWriter);
};
} // namespace transport_security_state

Powered by Google App Engine
This is Rietveld 408576698