Range request support for parallel download in DownloadRequestCore.

content/browser/download/download_request_core_unittest.cc

Index: content/browser/download/download_request_core_unittest.cc
diff --git a/content/browser/download/download_request_core_unittest.cc b/content/browser/download/download_request_core_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..71e45c23979c74e0a56d0153b89fe7e5fc03366d
--- /dev/null
+++ b/content/browser/download/download_request_core_unittest.cc
@@ -0,0 +1,140 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <memory>
+
+#include "base/memory/ptr_util.h"
+#include "base/run_loop.h"
+#include "content/browser/download/download_item_impl.h"
+#include "content/browser/download/download_request_core.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/download_url_parameters.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "net/http/http_request_headers.h"
+#include "net/url_request/url_request_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace content {
+
+class DownloadRequestCoreTest : public testing::Test {
+ public:
+  std::unique_ptr<DownloadUrlParameters> BuildDownloadParameters(
+      const std::string& url) const {
+    GURL gurl(url);
+    return base::MakeUnique<DownloadUrlParameters>(
+        gurl, request_context_getter_.get());
+  }
+
+  void CheckRequestHeaders(const std::string& name,
+                           const std::string& expected_header_value) const {
+    DCHECK(url_request_.get());
+    std::string header_value;
+    url_request_->extra_request_headers().GetHeader(name, &header_value);
+    EXPECT_EQ(expected_header_value, header_value);
+  }
+
+  bool HasRequestHeader(const std::string& name) {
+    DCHECK(url_request_.get());
+    return url_request_->extra_request_headers().HasHeader(name);
+  }
+
+  void CreateRequestOnIOThread(DownloadUrlParameters* params) {
+    url_request_ = DownloadRequestCore::CreateRequestOnIOThread(
+        DownloadItem::kInvalidId, params);
+    DCHECK(url_request_.get());
+  }
+
+  void SetUp() override {
+    request_context_getter_ = new net::TestURLRequestContextGetter(
+        content::BrowserThread::GetTaskRunnerForThread(
+            content::BrowserThread::UI));
+  }
+
+  void TearDown() override {
+    // URLRequest must be released before |request_context_getter_| gets
+    // destroyed.
+    url_request_.reset();
+  }
+
+  std::unique_ptr<net::URLRequest> url_request_;
+
+  // Used to test functions run on particular browser thread.
+  content::TestBrowserThreadBundle browser_threads_;
+  scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_;
+};
+
+// Ensure "Range" header is built correctly for normal download.
+TEST_F(DownloadRequestCoreTest, BuildRangeRequest) {
+  std::unique_ptr<DownloadUrlParameters> params =
+      BuildDownloadParameters("example.com");
+
+  // Check initial states.
+  EXPECT_EQ(DownloadSaveInfo::kLengthFullContent, params->length());
+  EXPECT_EQ(0, params->offset());
+
+  // Non-range request.
+  CreateRequestOnIOThread(params.get());
+  EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kRange));
+  EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfRange));
+  EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfMatch));
+  EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfUnmodifiedSince));
+  url_request_.reset();
+
+  // Range request with header "Range:bytes=50-99", and etag.
+  params->set_etag("123");
+  params->set_offset(50);
+  params->set_length(50);
+  CreateRequestOnIOThread(params.get());
+  CheckRequestHeaders(net::HttpRequestHeaders::kRange, "bytes=50-99");
+  EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfRange));
+  CheckRequestHeaders(net::HttpRequestHeaders::kIfMatch, "123");
+  CheckRequestHeaders(net::HttpRequestHeaders::kIfUnmodifiedSince, "");
+  url_request_.reset();
+
+  // Range request with header "Range:bytes=0-49" and last modified time.
+  std::string last_modified_time = "Tue, 15 Nov 1994 12:45:26 GMT";
+  params->set_etag("");
+  params->set_last_modified(last_modified_time);
+  params->set_offset(0);
+  params->set_length(50);
+  CreateRequestOnIOThread(params.get());
+  CheckRequestHeaders(net::HttpRequestHeaders::kRange, "bytes=0-49");
+  EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfRange));
+  EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfMatch));
+  CheckRequestHeaders(net::HttpRequestHeaders::kIfUnmodifiedSince,
+                      last_modified_time);
+  url_request_.reset();
+
+  // Range request with header "Range:bytes=10-59" and includes both etag and
+  // last modified time.
+  params->set_etag("123");
+  params->set_last_modified(last_modified_time);
+  params->set_offset(10);
+  params->set_length(50);
+  CreateRequestOnIOThread(params.get());
+  CheckRequestHeaders(net::HttpRequestHeaders::kRange, "bytes=10-59");
+  EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfRange));
+  CheckRequestHeaders(net::HttpRequestHeaders::kIfMatch, "123");
+  CheckRequestHeaders(net::HttpRequestHeaders::kIfUnmodifiedSince,
+                      last_modified_time);
+  url_request_.reset();
+}
+
+// Ensure "Range" header is built correctly for download resumption.
+// Notice download resumption requires strong validator(i.e. etag or
+// last-modified).
+TEST_F(DownloadRequestCoreTest, BuildRangeRequestWithoutLength) {
+  std::unique_ptr<DownloadUrlParameters> params =
+      BuildDownloadParameters("example.com");
+  params->set_etag("123");
+  params->set_offset(50);
+  CreateRequestOnIOThread(params.get());
+  CheckRequestHeaders(net::HttpRequestHeaders::kRange, "bytes=50-");
+  CheckRequestHeaders(net::HttpRequestHeaders::kIfRange, "123");
+  EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfMatch));
+  EXPECT_FALSE(HasRequestHeader(net::HttpRequestHeaders::kIfUnmodifiedSince));
+  url_request_.reset();
+}
+
+}  // namespace content