Issue 266076: Fix EventSendingController so that we do event saving and replay like what We...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266076: Fix EventSendingController so that we do event saving and replay like what We... (Closed)

Created:
11 years, 2 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix EventSendingController so that we do event saving and replay like what WebKit does. Also fix a bunch of small issues in EventSendingController. BUG=12197, 12477 TEST=existing layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29043

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -49 lines)			Patch
M	webkit/tools/layout_tests/test_expectations.txt	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	webkit/tools/test_shell/event_sending_controller.h	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/event_sending_controller.cc	View	1	12 chunks	+93 lines, -40 lines	2 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dglazkov

LGTM with nits: http://codereview.chromium.org/266076/diff/2001/3001 File webkit/tools/test_shell/event_sending_controller.cc (right): http://codereview.chromium.org/266076/diff/2001/3001#newcode288 Line 288: void EventSendingController::UpdateClickCountForButton(int button_number) { Can ...

11 years, 2 months ago (2009-10-14 01:32:00 UTC) #2

jianli

11 years, 2 months ago (2009-10-14 22:25:59 UTC) #3

All fixed and landed. Thanks.

On Tue, Oct 13, 2009 at 6:32 PM, <dglazkov@chromium.org> wrote:

> LGTM with nits:
>
>
> http://codereview.chromium.org/266076/diff/2001/3001
> File webkit/tools/test_shell/event_sending_controller.cc (right):
>
> http://codereview.chromium.org/266076/diff/2001/3001#newcode288
> Line 288: void EventSendingController::UpdateClickCountForButton(int
> button_number) {
> Can this take an enum instead?
>
> http://codereview.chromium.org/266076/diff/2001/3001#newcode580
> Line 580: /* static */ void EventSendingController::DoLeapForward(int
> milliseconds) {
> I think you should just do // static at the top of this line. Right?
>
>
> http://codereview.chromium.org/266076
>

Expand Messages | Collapse Messages