Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: services/video_capture/test/service_unittest.cc

Issue 2660743002: Merge video_capture tests into service_unittests (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/video_capture/test/mock_device_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ref_counted.h" 5 #include "base/memory/ref_counted.h"
6 #include "base/run_loop.h" 6 #include "base/run_loop.h"
7 #include "base/test/mock_callback.h" 7 #include "base/test/mock_callback.h"
8 #include "services/video_capture/public/interfaces/device_factory.mojom.h" 8 #include "services/video_capture/public/interfaces/device_factory.mojom.h"
9 #include "services/video_capture/test/service_test.h" 9 #include "services/video_capture/test/service_test.h"
10 10
11 using testing::Exactly; 11 using testing::Exactly;
12 using testing::_; 12 using testing::_;
13 using testing::Invoke; 13 using testing::Invoke;
14 using testing::InvokeWithoutArgs; 14 using testing::InvokeWithoutArgs;
15 15
16 namespace video_capture { 16 namespace video_capture {
17 17
18 // This alias ensures test output is easily attributed to this service's tests.
19 // TODO(rockot/chfremer): Consider just renaming the type.
20 using VideoCaptureServiceTest = ServiceTest;
21
18 // Tests that an answer arrives from the service when calling 22 // Tests that an answer arrives from the service when calling
19 // EnumerateDeviceDescriptors(). 23 // EnumerateDeviceDescriptors().
20 TEST_F(ServiceTest, DISABLED_EnumerateDeviceDescriptorsCallbackArrives) { 24 TEST_F(VideoCaptureServiceTest,
25 DISABLED_EnumerateDeviceDescriptorsCallbackArrives) {
21 base::RunLoop wait_loop; 26 base::RunLoop wait_loop;
22 EXPECT_CALL(descriptor_receiver_, Run(_)) 27 EXPECT_CALL(descriptor_receiver_, Run(_))
23 .Times(Exactly(1)) 28 .Times(Exactly(1))
24 .WillOnce(InvokeWithoutArgs([&wait_loop]() { wait_loop.Quit(); })); 29 .WillOnce(InvokeWithoutArgs([&wait_loop]() { wait_loop.Quit(); }));
25 30
26 factory_->EnumerateDeviceDescriptors(descriptor_receiver_.Get()); 31 factory_->EnumerateDeviceDescriptors(descriptor_receiver_.Get());
27 wait_loop.Run(); 32 wait_loop.Run();
28 } 33 }
29 34
30 TEST_F(ServiceTest, DISABLED_FakeDeviceFactoryEnumeratesOneDevice) { 35 TEST_F(VideoCaptureServiceTest, DISABLED_FakeDeviceFactoryEnumeratesOneDevice) {
31 base::RunLoop wait_loop; 36 base::RunLoop wait_loop;
32 size_t num_devices_enumerated = 0; 37 size_t num_devices_enumerated = 0;
33 EXPECT_CALL(descriptor_receiver_, Run(_)) 38 EXPECT_CALL(descriptor_receiver_, Run(_))
34 .Times(Exactly(1)) 39 .Times(Exactly(1))
35 .WillOnce(Invoke([&wait_loop, &num_devices_enumerated]( 40 .WillOnce(Invoke([&wait_loop, &num_devices_enumerated](
36 const std::vector<media::VideoCaptureDeviceDescriptor>& descriptors) { 41 const std::vector<media::VideoCaptureDeviceDescriptor>& descriptors) {
37 num_devices_enumerated = descriptors.size(); 42 num_devices_enumerated = descriptors.size();
38 wait_loop.Quit(); 43 wait_loop.Quit();
39 })); 44 }));
40 45
41 factory_->EnumerateDeviceDescriptors(descriptor_receiver_.Get()); 46 factory_->EnumerateDeviceDescriptors(descriptor_receiver_.Get());
42 wait_loop.Run(); 47 wait_loop.Run();
43 ASSERT_EQ(1u, num_devices_enumerated); 48 ASSERT_EQ(1u, num_devices_enumerated);
44 } 49 }
45 50
46 // Tests that VideoCaptureDeviceFactory::CreateDeviceProxy() returns an error 51 // Tests that VideoCaptureDeviceFactory::CreateDeviceProxy() returns an error
47 // code when trying to create a device for an invalid descriptor. 52 // code when trying to create a device for an invalid descriptor.
48 TEST_F(ServiceTest, DISABLED_ErrorCodeOnCreateDeviceForInvalidDescriptor) { 53 TEST_F(VideoCaptureServiceTest,
54 DISABLED_ErrorCodeOnCreateDeviceForInvalidDescriptor) {
49 const std::string invalid_device_id = "invalid"; 55 const std::string invalid_device_id = "invalid";
50 base::RunLoop wait_loop; 56 base::RunLoop wait_loop;
51 mojom::DevicePtr fake_device_proxy; 57 mojom::DevicePtr fake_device_proxy;
52 base::MockCallback<mojom::DeviceFactory::CreateDeviceCallback> 58 base::MockCallback<mojom::DeviceFactory::CreateDeviceCallback>
53 create_device_proxy_callback; 59 create_device_proxy_callback;
54 EXPECT_CALL(create_device_proxy_callback, 60 EXPECT_CALL(create_device_proxy_callback,
55 Run(mojom::DeviceAccessResultCode::ERROR_DEVICE_NOT_FOUND)) 61 Run(mojom::DeviceAccessResultCode::ERROR_DEVICE_NOT_FOUND))
56 .Times(1) 62 .Times(1)
57 .WillOnce(InvokeWithoutArgs([&wait_loop]() { wait_loop.Quit(); })); 63 .WillOnce(InvokeWithoutArgs([&wait_loop]() { wait_loop.Quit(); }));
58 factory_->CreateDevice(invalid_device_id, 64 factory_->CreateDevice(invalid_device_id,
59 mojo::MakeRequest(&fake_device_proxy), 65 mojo::MakeRequest(&fake_device_proxy),
60 create_device_proxy_callback.Get()); 66 create_device_proxy_callback.Get());
61 wait_loop.Run(); 67 wait_loop.Run();
62 } 68 }
63 69
64 } // namespace video_capture 70 } // namespace video_capture
OLDNEW
« no previous file with comments | « services/video_capture/test/mock_device_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698