Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: mojo/public/cpp/bindings/lib/control_message_proxy.cc

Issue 2660733002: Mojo C++ bindings: introduce an optional array to store transferred interface IDs in messages. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/control_message_proxy.cc
diff --git a/mojo/public/cpp/bindings/lib/control_message_proxy.cc b/mojo/public/cpp/bindings/lib/control_message_proxy.cc
index 44db40c2ac9065de6fb90b9e37b940438283710d..23de991309f140b13511d1d7892111e49361a2b6 100644
--- a/mojo/public/cpp/bindings/lib/control_message_proxy.cc
+++ b/mojo/public/cpp/bindings/lib/control_message_proxy.cc
@@ -24,9 +24,9 @@ namespace internal {
namespace {
bool ValidateControlResponse(Message* message) {
- ValidationContext validation_context(
- message->data(), message->data_num_bytes(), message->handles()->size(),
- message, "ControlResponseValidator");
+ ValidationContext validation_context(message->payload(),
+ message->payload_num_bytes(), 0, 0,
+ message, "ControlResponseValidator");
if (!ValidateMessageIsResponse(message, &validation_context))
return false;
@@ -79,7 +79,8 @@ void SendRunMessage(MessageReceiverWithResponder* receiver,
params_ptr->input = std::move(input_ptr);
size_t size = PrepareToSerialize<interface_control::RunMessageParamsDataView>(
params_ptr, &context);
- RequestMessageBuilder builder(interface_control::kRunMessageId, size);
+ MessageBuilder builder(interface_control::kRunMessageId,
+ Message::kFlagExpectsResponse, size, 0);
interface_control::internal::RunMessageParams_Data* params = nullptr;
Serialize<interface_control::RunMessageParamsDataView>(
@@ -99,7 +100,8 @@ Message ConstructRunOrClosePipeMessage(
size_t size = PrepareToSerialize<
interface_control::RunOrClosePipeMessageParamsDataView>(params_ptr,
&context);
- MessageBuilder builder(interface_control::kRunOrClosePipeMessageId, size);
+ MessageBuilder builder(interface_control::kRunOrClosePipeMessageId, 0, size,
+ 0);
interface_control::internal::RunOrClosePipeMessageParams_Data* params =
nullptr;
« no previous file with comments | « mojo/public/cpp/bindings/lib/control_message_handler.cc ('k') | mojo/public/cpp/bindings/lib/handle_interface_serialization.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698