Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: mojo/public/cpp/bindings/lib/control_message_handler.cc

Issue 2660733002: Mojo C++ bindings: introduce an optional array to store transferred interface IDs in messages. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/public/cpp/bindings/lib/control_message_handler.h" 5 #include "mojo/public/cpp/bindings/lib/control_message_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <utility> 9 #include <utility>
10 10
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "mojo/public/cpp/bindings/lib/message_builder.h" 12 #include "mojo/public/cpp/bindings/lib/message_builder.h"
13 #include "mojo/public/cpp/bindings/lib/serialization.h" 13 #include "mojo/public/cpp/bindings/lib/serialization.h"
14 #include "mojo/public/cpp/bindings/lib/validation_util.h" 14 #include "mojo/public/cpp/bindings/lib/validation_util.h"
15 #include "mojo/public/interfaces/bindings/interface_control_messages.mojom.h" 15 #include "mojo/public/interfaces/bindings/interface_control_messages.mojom.h"
16 16
17 namespace mojo { 17 namespace mojo {
18 namespace internal { 18 namespace internal {
19 namespace { 19 namespace {
20 20
21 bool ValidateControlRequestWithResponse(Message* message) { 21 bool ValidateControlRequestWithResponse(Message* message) {
22 ValidationContext validation_context( 22 ValidationContext validation_context(message->payload(),
23 message->data(), message->data_num_bytes(), message->handles()->size(), 23 message->payload_num_bytes(), 0, 0,
24 message, "ControlRequestValidator"); 24 message, "ControlRequestValidator");
25 if (!ValidateMessageIsRequestExpectingResponse(message, &validation_context)) 25 if (!ValidateMessageIsRequestExpectingResponse(message, &validation_context))
26 return false; 26 return false;
27 27
28 switch (message->header()->name) { 28 switch (message->header()->name) {
29 case interface_control::kRunMessageId: 29 case interface_control::kRunMessageId:
30 return ValidateMessagePayload< 30 return ValidateMessagePayload<
31 interface_control::internal::RunMessageParams_Data>( 31 interface_control::internal::RunMessageParams_Data>(
32 message, &validation_context); 32 message, &validation_context);
33 } 33 }
34 return false; 34 return false;
35 } 35 }
36 36
37 bool ValidateControlRequestWithoutResponse(Message* message) { 37 bool ValidateControlRequestWithoutResponse(Message* message) {
38 ValidationContext validation_context( 38 ValidationContext validation_context(message->payload(),
39 message->data(), message->data_num_bytes(), message->handles()->size(), 39 message->payload_num_bytes(), 0, 0,
40 message, "ControlRequestValidator"); 40 message, "ControlRequestValidator");
41 if (!ValidateMessageIsRequestWithoutResponse(message, &validation_context)) 41 if (!ValidateMessageIsRequestWithoutResponse(message, &validation_context))
42 return false; 42 return false;
43 43
44 switch (message->header()->name) { 44 switch (message->header()->name) {
45 case interface_control::kRunOrClosePipeMessageId: 45 case interface_control::kRunOrClosePipeMessageId:
46 return ValidateMessageIsRequestWithoutResponse(message, 46 return ValidateMessageIsRequestWithoutResponse(message,
47 &validation_context) && 47 &validation_context) &&
48 ValidateMessagePayload< 48 ValidateMessagePayload<
49 interface_control::internal::RunOrClosePipeMessageParams_Data>( 49 interface_control::internal::RunOrClosePipeMessageParams_Data>(
50 message, &validation_context); 50 message, &validation_context);
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 output.reset(); 109 output.reset();
110 } else { 110 } else {
111 output.reset(); 111 output.reset();
112 } 112 }
113 113
114 auto response_params_ptr = interface_control::RunResponseMessageParams::New(); 114 auto response_params_ptr = interface_control::RunResponseMessageParams::New();
115 response_params_ptr->output = std::move(output); 115 response_params_ptr->output = std::move(output);
116 size_t size = 116 size_t size =
117 PrepareToSerialize<interface_control::RunResponseMessageParamsDataView>( 117 PrepareToSerialize<interface_control::RunResponseMessageParamsDataView>(
118 response_params_ptr, &context_); 118 response_params_ptr, &context_);
119 ResponseMessageBuilder builder(interface_control::kRunMessageId, size, 119 MessageBuilder builder(interface_control::kRunMessageId,
120 message->request_id()); 120 Message::kFlagIsResponse, size, 0);
121 builder.message()->set_request_id(message->request_id());
121 122
122 interface_control::internal::RunResponseMessageParams_Data* response_params = 123 interface_control::internal::RunResponseMessageParams_Data* response_params =
123 nullptr; 124 nullptr;
124 Serialize<interface_control::RunResponseMessageParamsDataView>( 125 Serialize<interface_control::RunResponseMessageParamsDataView>(
125 response_params_ptr, builder.buffer(), &response_params, &context_); 126 response_params_ptr, builder.buffer(), &response_params, &context_);
126 bool ok = responder->Accept(builder.message()); 127 bool ok = responder->Accept(builder.message());
127 ALLOW_UNUSED_LOCAL(ok); 128 ALLOW_UNUSED_LOCAL(ok);
128 delete responder; 129 delete responder;
129 130
130 return true; 131 return true;
131 } 132 }
132 133
133 bool ControlMessageHandler::RunOrClosePipe(Message* message) { 134 bool ControlMessageHandler::RunOrClosePipe(Message* message) {
134 interface_control::internal::RunOrClosePipeMessageParams_Data* params = 135 interface_control::internal::RunOrClosePipeMessageParams_Data* params =
135 reinterpret_cast< 136 reinterpret_cast<
136 interface_control::internal::RunOrClosePipeMessageParams_Data*>( 137 interface_control::internal::RunOrClosePipeMessageParams_Data*>(
137 message->mutable_payload()); 138 message->mutable_payload());
138 interface_control::RunOrClosePipeMessageParamsPtr params_ptr; 139 interface_control::RunOrClosePipeMessageParamsPtr params_ptr;
139 Deserialize<interface_control::RunOrClosePipeMessageParamsDataView>( 140 Deserialize<interface_control::RunOrClosePipeMessageParamsDataView>(
140 params, &params_ptr, &context_); 141 params, &params_ptr, &context_);
141 auto& input = *params_ptr->input; 142 auto& input = *params_ptr->input;
142 if (input.is_require_version()) 143 if (input.is_require_version())
143 return interface_version_ >= input.get_require_version()->version; 144 return interface_version_ >= input.get_require_version()->version;
144 145
145 return false; 146 return false;
146 } 147 }
147 148
148 } // namespace internal 149 } // namespace internal
149 } // namespace mojo 150 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/public/cpp/bindings/lib/bindings_internal.h ('k') | mojo/public/cpp/bindings/lib/control_message_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698