Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2660703002: Filter out 'FileSystemException: Failed to watch path' from _PhysicalFolder.changes. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Filter out 'FileSystemException: Failed to watch path' from _PhysicalFolder.changes. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/81b725aa3f7c4bca1272a70b387cbecefae52230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-01-27 20:34:16 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-01-27 20:41:14 UTC) #2
scheglov
3 years, 10 months ago (2017-01-27 21:23:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
81b725aa3f7c4bca1272a70b387cbecefae52230 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698