Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 26607002: PNaCl: Allow translator to produce an unsandboxed, native executable (Closed)

Created:
7 years, 2 months ago by Mark Seaborn
Modified:
7 years, 2 months ago
Reviewers:
Derek Schuff, eliben
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

PNaCl: Allow translator to produce an unsandboxed, native executable This only works for targeting x86-32 Linux in this initial version. This allows pnacl-translate to be invoked with "-arch linux-x86-32". I'll extend this to work on x86-64 and Mac in later changes. * Add a minimal IRT implementation that's just enough to run hello_world.pexe. It implements TLS, mmap(), write(), exit(), etc. I'll implement more IRT interfaces in a later change. * For testing, add a Buildbot step to test this, and add the "pnacl_unsandboxed" option to Scons. This change is a retry of r12218, with a DEPS change to fix checkdeps, plus a comment. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3699 TEST=run_hello_world_test_irt bitcode=1 pnacl_unsandboxed=1 --mode=nacl_irt_test Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12234

Patch Set 1 #

Patch Set 2 : Fix checkdeps #

Total comments: 2

Patch Set 3 : Add comment #

Patch Set 4 : Expand on comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -10 lines) Patch
M SConstruct View 2 chunks +7 lines, -0 lines 0 comments Download
M buildbot/buildbot_pnacl.sh View 1 chunk +6 lines, -0 lines 0 comments Download
M pnacl/build.sh View 2 chunks +13 lines, -0 lines 0 comments Download
M pnacl/driver/driver_log.py View 1 chunk +2 lines, -0 lines 0 comments Download
M pnacl/driver/pnacl-translate.py View 7 chunks +27 lines, -10 lines 0 comments Download
M pnacl/support/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
A pnacl/support/unsandboxed_irt.c View 1 2 3 1 chunk +206 lines, -0 lines 0 comments Download
M site_scons/site_tools/naclsdk.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mark Seaborn
Same as before, but with the fix in patch set 2.
7 years, 2 months ago (2013-10-08 23:18:59 UTC) #1
Derek Schuff
lgtm
7 years, 2 months ago (2013-10-08 23:21:14 UTC) #2
eliben
https://codereview.chromium.org/26607002/diff/3001/pnacl/support/unsandboxed_irt.c File pnacl/support/unsandboxed_irt.c (right): https://codereview.chromium.org/26607002/diff/3001/pnacl/support/unsandboxed_irt.c#newcode21 pnacl/support/unsandboxed_irt.c:21: A comment in this file explaining what it contains ...
7 years, 2 months ago (2013-10-08 23:24:16 UTC) #3
Mark Seaborn
https://codereview.chromium.org/26607002/diff/3001/pnacl/support/unsandboxed_irt.c File pnacl/support/unsandboxed_irt.c (right): https://codereview.chromium.org/26607002/diff/3001/pnacl/support/unsandboxed_irt.c#newcode21 pnacl/support/unsandboxed_irt.c:21: On 2013/10/08 23:24:16, eliben wrote: > A comment in ...
7 years, 2 months ago (2013-10-10 23:55:48 UTC) #4
eliben
On Thu, Oct 10, 2013 at 4:55 PM, <mseaborn@chromium.org> wrote: > > https://codereview.chromium.**org/26607002/diff/3001/pnacl/** > support/unsandboxed_irt.c<https://codereview.chromium.org/26607002/diff/3001/pnacl/support/unsandboxed_irt.c> ...
7 years, 2 months ago (2013-10-11 00:00:45 UTC) #5
Mark Seaborn
7 years, 2 months ago (2013-10-11 06:52:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r12234 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698