components/sync/model_impl/shared_model_type_processor.cc - Issue 2660673002: [Sync] Not having an autocomplete ModelTypeState is valid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model_impl/shared_model_type_processor.cc

Issue 2660673002: [Sync] Not having an autocomplete ModelTypeState is valid. (Closed)

Patch Set: Update AutocompleteSyncBridge unittests to not rely on initial metadata. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/model_impl/shared_model_type_processor.cc

diff --git a/components/sync/model_impl/shared_model_type_processor.cc b/components/sync/model_impl/shared_model_type_processor.cc

index 5081f139315224adb77d4d74969f1ddf24ad3cf8..614321deacdfc7277bb408809c4a3ed1a00b9582 100644

--- a/components/sync/model_impl/shared_model_type_processor.cc

+++ b/components/sync/model_impl/shared_model_type_processor.cc

@@ -82,6 +82,7 @@ void SharedModelTypeProcessor::ModelReadyToSync(

weak_ptr_factory_.GetWeakPtr()));

}

} else {

+ DCHECK_EQ(0u, batch->TakeAllMetadata().size());

// First time syncing; initialize metadata.

model_type_state_.mutable_progress_marker()->set_data_type_id(

GetSpecificsFieldNumberFromModelType(type_));