Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 26606004: change SkAnnotation to not inherit from SkFlattenable (does not need dynamic factories) (Closed)

Created:
7 years, 2 months ago by reed1
Modified:
7 years, 2 months ago
Reviewers:
scroggo, mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

change SkAnnotation to not inherit from SkFlattenable (does not need dynamic factories) BUG= R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=11762

Patch Set 1 #

Patch Set 2 : #

Total comments: 12

Patch Set 3 : use data slot in op32 to store bool for empty annotation" #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -22 lines) Patch
M include/core/SkAnnotation.h View 1 2 3 chunks +6 lines, -10 lines 0 comments Download
M src/core/SkAnnotation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +11 lines, -2 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 2 3 4 chunks +19 lines, -3 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 2 2 chunks +20 lines, -1 line 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
reed1
7 years, 2 months ago (2013-10-14 17:40:00 UTC) #1
reed1
patch #2 makes empty-annotations correctly write/read a 0 for length
7 years, 2 months ago (2013-10-14 18:32:41 UTC) #2
scroggo
https://codereview.chromium.org/26606004/diff/4001/include/core/SkAnnotation.h File include/core/SkAnnotation.h (right): https://codereview.chromium.org/26606004/diff/4001/include/core/SkAnnotation.h#newcode11 include/core/SkAnnotation.h:11: #include "SkFlattenable.h" Can this be removed? https://codereview.chromium.org/26606004/diff/4001/src/pipe/SkGPipeRead.cpp File src/pipe/SkGPipeRead.cpp ...
7 years, 2 months ago (2013-10-14 18:47:19 UTC) #3
reed1
https://codereview.chromium.org/26606004/diff/4001/include/core/SkAnnotation.h File include/core/SkAnnotation.h (right): https://codereview.chromium.org/26606004/diff/4001/include/core/SkAnnotation.h#newcode11 include/core/SkAnnotation.h:11: #include "SkFlattenable.h" On 2013/10/14 18:47:19, scroggo wrote: > Can ...
7 years, 2 months ago (2013-10-14 19:38:41 UTC) #4
scroggo
lgtm, so long as it doesn't throw a warning for treating unsigned as a bool. ...
7 years, 2 months ago (2013-10-14 19:47:27 UTC) #5
reed1
https://codereview.chromium.org/26606004/diff/13001/src/pipe/SkGPipeRead.cpp File src/pipe/SkGPipeRead.cpp (right): https://codereview.chromium.org/26606004/diff/13001/src/pipe/SkGPipeRead.cpp#newcode677 src/pipe/SkGPipeRead.cpp:677: if (PaintOp_unpackData(op32)) { On 2013/10/14 19:47:27, scroggo wrote: > ...
7 years, 2 months ago (2013-10-14 19:55:44 UTC) #6
scroggo
On 2013/10/14 19:55:44, reed1 wrote: > https://codereview.chromium.org/26606004/diff/13001/src/pipe/SkGPipeRead.cpp > File src/pipe/SkGPipeRead.cpp (right): > > https://codereview.chromium.org/26606004/diff/13001/src/pipe/SkGPipeRead.cpp#newcode677 > ...
7 years, 2 months ago (2013-10-14 19:59:11 UTC) #7
reed1
7 years, 2 months ago (2013-10-14 20:02:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r11762 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698