Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Unified Diff: ui/views/controls/textfield/textfield.h

Issue 2660593002: Paint text cursor in LAYER_SOLID_COLOR (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield.h
diff --git a/ui/views/controls/textfield/textfield.h b/ui/views/controls/textfield/textfield.h
index 69d7b462bffc4694539a20479bb55443e58c334c..b51b89504700a8bcbbbfc42cfc4c79bc5e914866 100644
--- a/ui/views/controls/textfield/textfield.h
+++ b/ui/views/controls/textfield/textfield.h
@@ -374,7 +374,7 @@ class VIEWS_EXPORT Textfield : public View,
void UpdateCursor();
// Repaint the cursor.
sadrul 2017/02/07 04:19:35 Update the comment.
yiyix 2017/02/08 19:47:40 Done.
- void RepaintCursor();
+ void UpdateCursorView();
void PaintTextAndCursor(gfx::Canvas* canvas);
@@ -524,6 +524,9 @@ class VIEWS_EXPORT Textfield : public View,
std::unique_ptr<ui::SimpleMenuModel> context_menu_contents_;
std::unique_ptr<views::MenuRunner> context_menu_runner_;
+ // View containing the text cursor.
+ View cursor_view_;
+
// Used to bind callback functions to this object.
base::WeakPtrFactory<Textfield> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698