Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: ui/views/window/dialog_client_view_unittest.cc

Issue 2660553005: Harmony - convert hung renderer dialog. (Closed)
Patch Set: disable dialog test on osx Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/window/dialog_client_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/window/dialog_client_view_unittest.cc
diff --git a/ui/views/window/dialog_client_view_unittest.cc b/ui/views/window/dialog_client_view_unittest.cc
index e1f28b4dc35bf06d7129836c5d004f2e59000ffb..f5d8add5318173e3d3754bee942390d818384c3d 100644
--- a/ui/views/window/dialog_client_view_unittest.cc
+++ b/ui/views/window/dialog_client_view_unittest.cc
@@ -54,7 +54,7 @@ class DialogClientViewTest : public ViewsTestBase,
void SetUp() override {
dialog_buttons_ = ui::DIALOG_BUTTON_NONE;
client_view_.reset(new TestDialogClientView(this));
- // Add this i.e. the contents view as a child of |client_view_|. This is
+ // Add this (i.e. the contents view) as a child of |client_view_|. This is
// generally done when the client view is added to the view hierarchy.
client_view_->AddChildViewAt(this, 0);
ViewsTestBase::SetUp();
@@ -224,6 +224,7 @@ TEST_F(DialogClientViewTest, ContentsSize) {
TEST_F(DialogClientViewTest, LayoutWithButtons) {
SetDialogButtons(ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL);
CheckContentsIsSetToPreferredSize();
+
EXPECT_LT(GetContentsView()->bounds().bottom(),
client_view()->bounds().bottom());
gfx::Size no_extra_view_size = client_view()->bounds().size();
« no previous file with comments | « ui/views/window/dialog_client_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698