Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1799)

Unified Diff: chrome/browser/ui/views/hung_renderer_view.h

Issue 2660553005: Harmony - convert hung renderer dialog. (Closed)
Patch Set: disable dialog test on osx Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/harmony/layout_delegate.cc ('k') | chrome/browser/ui/views/hung_renderer_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/hung_renderer_view.h
diff --git a/chrome/browser/ui/views/hung_renderer_view.h b/chrome/browser/ui/views/hung_renderer_view.h
index 751cf56c2e0aae7a0bc55fb40fd996874d8eaa68..b46ee1ed5cd4206d95adcfe470fe6cb2601d2851 100644
--- a/chrome/browser/ui/views/hung_renderer_view.h
+++ b/chrome/browser/ui/views/hung_renderer_view.h
@@ -22,7 +22,6 @@ class WebContents;
namespace views {
class Label;
-class LabelButton;
}
// Provides functionality to display information about a hung renderer.
@@ -96,7 +95,6 @@ class HungPagesTableModel : public ui::TableModel, public views::TableGrouper {
// This class displays a dialog which contains information about a hung
// renderer process.
class HungRendererDialogView : public views::DialogDelegateView,
- public views::ButtonListener,
public HungPagesTableModel::Delegate {
public:
// Factory function for creating an instance of the HungRendererDialogView
@@ -125,13 +123,11 @@ class HungRendererDialogView : public views::DialogDelegateView,
void WindowClosing() override;
int GetDialogButtons() const override;
base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
- views::View* CreateExtraView() override;
bool Cancel() override;
+ bool Accept() override;
+ bool Close() override;
bool ShouldUseCustomFrame() const override;
- // views::ButtonListener overrides:
- void ButtonPressed(views::Button* sender, const ui::Event& event) override;
-
// HungPagesTableModel::Delegate overrides:
void TabDestroyed() override;
@@ -160,9 +156,6 @@ class HungRendererDialogView : public views::DialogDelegateView,
// Controls within the dialog box.
views::TableView* hung_pages_table_;
- // The extra button inserted into the ClientView to kill the errant process.
- views::LabelButton* kill_button_;
-
// The model that provides the contents of the table that shows a list of
// pages affected by the hang.
std::unique_ptr<HungPagesTableModel> hung_pages_table_model_;
@@ -170,8 +163,6 @@ class HungRendererDialogView : public views::DialogDelegateView,
// Whether or not we've created controls for ourself.
bool initialized_;
- bool kill_button_clicked_;
-
// A copy of the unresponsive state which ShowForWebContents was
// called with.
content::WebContentsUnresponsiveState unresponsive_state_;
« no previous file with comments | « chrome/browser/ui/views/harmony/layout_delegate.cc ('k') | chrome/browser/ui/views/hung_renderer_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698