Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: chrome/browser/ui/views/harmony/layout_delegate.h

Issue 2660553005: Harmony - convert hung renderer dialog. (Closed)
Patch Set: disable dialog test on osx Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/harmony/layout_delegate.h
diff --git a/chrome/browser/ui/views/harmony/layout_delegate.h b/chrome/browser/ui/views/harmony/layout_delegate.h
index 6213d1c90c0484e3b5df65635f49cb379dd6b816..4f39146e0e803a2daf736d7a15ed0d0076d6226d 100644
--- a/chrome/browser/ui/views/harmony/layout_delegate.h
+++ b/chrome/browser/ui/views/harmony/layout_delegate.h
@@ -10,12 +10,14 @@
class LayoutDelegate {
public:
enum class Metric {
+ // Padding on the left and right side of a button's label.
+ BUTTON_HORIZONTAL_PADDING,
// Margin between the edge of a dialog and the left, right, or bottom of a
// contained button.
DIALOG_BUTTON_MARGIN,
- // In theory, this is the spacing between a dialog button and the content
- // above it. In practice, what the code does with this value, at least
- // pre-Harmony, defies easy explanation.
+ // Minimum width of a dialog button.
+ DIALOG_BUTTON_MINIMUM_WIDTH,
+ // Spacing between a dialog button and the content above it.
DIALOG_BUTTON_TOP_SPACING,
// Horizontal or vertical margin between the edge of a dialog and the close
// button in the upper trailing corner.
@@ -36,6 +38,10 @@ class LayoutDelegate {
// Horizontal indent of a subsection relative to related items above, e.g.
// checkboxes below explanatory text/headings.
SUBSECTION_HORIZONTAL_INDENT,
+ // Horizontal spacing between controls that are logically unrelated.
+ UNRELATED_CONTROL_HORIZONTAL_SPACING,
+ // Larger horizontal spacing between unrelated controls.
+ UNRELATED_CONTROL_HORIZONTAL_SPACING_LARGE,
// Vertical spacing between controls that are logically unrelated.
UNRELATED_CONTROL_VERTICAL_SPACING,
// Larger vertical spacing between unrelated controls.
« no previous file with comments | « chrome/browser/ui/views/harmony/harmony_layout_delegate.cc ('k') | chrome/browser/ui/views/harmony/layout_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698