Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: chrome/browser/ui/views/harmony/harmony_layout_delegate.cc

Issue 2660553005: Harmony - convert hung renderer dialog. (Closed)
Patch Set: comments 4 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
diff --git a/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc b/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
index eb1744312dc81b417ddc686c76ef3fcb861ada54..45cb24b059f216a32cfa5b124dbefd104427b4c7 100644
--- a/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
+++ b/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
@@ -17,8 +17,14 @@ HarmonyLayoutDelegate* HarmonyLayoutDelegate::Get() {
int HarmonyLayoutDelegate::GetMetric(Metric metric) const {
switch (metric) {
+ case Metric::BUTTON_HORIZONTAL_PADDING:
+ return kHarmonyLayoutUnit;
case Metric::DIALOG_BUTTON_MARGIN:
return kHarmonyLayoutUnit;
+ case Metric::DIALOG_BUTTON_MINIMUM_WIDTH:
+ // Minimum label size plus padding.
Peter Kasting 2017/02/16 01:14:47 Maybe we should just expose the minimum label widt
Bret 2017/02/16 01:31:04 I think this is okay.
+ return 2 * kHarmonyLayoutUnit +
+ 2 * GetMetric(Metric::BUTTON_HORIZONTAL_PADDING);
case Metric::DIALOG_BUTTON_TOP_SPACING:
return kHarmonyLayoutUnit;
case Metric::DIALOG_CLOSE_BUTTON_MARGIN:
@@ -37,6 +43,10 @@ int HarmonyLayoutDelegate::GetMetric(Metric metric) const {
return kHarmonyLayoutUnit;
case Metric::SUBSECTION_HORIZONTAL_INDENT:
return 0;
+ case Metric::UNRELATED_CONTROL_HORIZONTAL_SPACING:
+ return kHarmonyLayoutUnit;
+ case Metric::UNRELATED_CONTROL_HORIZONTAL_SPACING_LARGE:
+ return kHarmonyLayoutUnit;
case Metric::UNRELATED_CONTROL_VERTICAL_SPACING:
return kHarmonyLayoutUnit;
case Metric::UNRELATED_CONTROL_VERTICAL_SPACING_LARGE:

Powered by Google App Engine
This is Rietveld 408576698