Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5386)

Unified Diff: chrome/browser/ui/views/harmony/layout_delegate.h

Issue 2660553005: Harmony - convert hung renderer dialog. (Closed)
Patch Set: comments 3 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/harmony/layout_delegate.h
diff --git a/chrome/browser/ui/views/harmony/layout_delegate.h b/chrome/browser/ui/views/harmony/layout_delegate.h
index 6213d1c90c0484e3b5df65635f49cb379dd6b816..6ee319f960e0c165aa0a7fbf88fbd3e1b2a881a6 100644
--- a/chrome/browser/ui/views/harmony/layout_delegate.h
+++ b/chrome/browser/ui/views/harmony/layout_delegate.h
@@ -13,6 +13,8 @@ class LayoutDelegate {
// Margin between the edge of a dialog and the left, right, or bottom of a
// contained button.
DIALOG_BUTTON_MARGIN,
+ // Minimum width of a dialog button.
+ DIALOG_BUTTON_MINIMUM_WIDTH,
// In theory, this is the spacing between a dialog button and the content
// above it. In practice, what the code does with this value, at least
// pre-Harmony, defies easy explanation.
Peter Kasting 2017/02/13 23:47:31 Nit: This comment might be simplifiable (to just t
Bret 2017/02/16 00:25:01 Done.
@@ -36,6 +38,8 @@ class LayoutDelegate {
// Horizontal indent of a subsection relative to related items above, e.g.
// checkboxes below explanatory text/headings.
SUBSECTION_HORIZONTAL_INDENT,
+ // Larger horizontal spacing between unrelated controls.
Peter Kasting 2017/02/13 23:47:31 Nit: I wonder if you should just go ahead and add
Bret 2017/02/16 00:25:01 Done.
+ UNRELATED_CONTROL_HORIZONTAL_SPACING_LARGE,
// Vertical spacing between controls that are logically unrelated.
UNRELATED_CONTROL_VERTICAL_SPACING,
// Larger vertical spacing between unrelated controls.

Powered by Google App Engine
This is Rietveld 408576698