Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: chrome/browser/ui/views/hung_renderer_view_browsertest.cc

Issue 2660553005: Harmony - convert hung renderer dialog. (Closed)
Patch Set: merge Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
tapted 2017/02/03 02:07:54 nit: remove (c)
Bret 2017/02/03 21:58:35 Done.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <string>
6
7 #include "base/command_line.h"
8 #include "chrome/browser/platform_util.h"
9 #include "chrome/browser/ui/browser.cc"
10 #include "chrome/browser/ui/tab_dialogs.h"
11 #include "chrome/browser/ui/tabs/tab_strip_model.h"
12 #include "chrome/browser/ui/test/test_browser_dialog.h"
13 #include "chrome/browser/ui/views/hung_renderer_view.h"
14 #include "content/public/browser/web_contents_unresponsive_state.h"
15 #include "ui/base/ui_base_switches.h"
16
17 // TODO(crbug.com/687387): If the dialog is invisible when invoked interactively
18 // pass --disable-gpu as a workaround.
tapted 2017/02/03 02:07:54 perhaps merge in the stuff from https://codereview
Bret 2017/02/03 21:58:35 Okay I coordinated with Allen and pulled in his wo
19 class HungRendererDialogViewBrowserTest : public DialogBrowserTest {
20 public:
21 HungRendererDialogViewBrowserTest() {}
22
23 // DialogBrowserTest:
24 void ShowDialog(const std::string& name) override {
25 content::WebContents* web_contents =
26 browser()->tab_strip_model()->GetActiveWebContents();
27 TabDialogs::FromWebContents(web_contents)
28 ->ShowHungRendererDialog(content::WebContentsUnresponsiveState());
29 }
30
31 // content::BrowserTestBase:
32 void SetUpCommandLine(base::CommandLine* command_line) override {
33 command_line->AppendSwitch(switches::kExtendMdToSecondaryUi);
34 }
35
36 private:
37 DISALLOW_COPY_AND_ASSIGN(HungRendererDialogViewBrowserTest);
38 };
39
40 // Invokes the hung renderer (aka page unresponsive) dialog. See
41 // test_browser_dialog.h.
42 IN_PROC_BROWSER_TEST_F(HungRendererDialogViewBrowserTest,
43 InvokeDialog_default) {
44 RunDialog();
45 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698