Harmony - convert hung renderer dialog.

chrome/browser/ui/views/hung_renderer_view_browsertest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[tapted, 2017/02/01 00:52:48]

nit: 2017

[Bret, 2017/02/01 02:21:46]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "base/command_line.h"
+#include "chrome/browser/platform_util.h"
+#include "chrome/browser/ui/browser.cc"
+#include "chrome/browser/ui/tab_dialogs.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/test/test_browser_dialog.h"
+#include "chrome/browser/ui/views/hung_renderer_view.h"
+#include "content/public/browser/web_contents_unresponsive_state.h"
+#include "ui/base/ui_base_switches.h"
+
+// TODO(crbug.com/687387): If the dialog is invisible when invoked interactively
+// pass --disable-gpu as a workaround.
+class HungRendererDialogViewBrowserTest : public DialogBrowserTest {
+ public:
+  HungRendererDialogViewBrowserTest() {}
+
+  // TestDialogInterface:

[tapted, 2017/02/01 00:52:48]

// DialogBrowserTest:

(sorry - I'll update that doc where this was taken from)

[Bret, 2017/02/01 02:21:46]

Done. I took it from the collected cookies version actually; updated there too.

+  void ShowDialog(const std::string& name) override {
+    content::WebContents* web_contents =
+        browser()->tab_strip_model()->GetActiveWebContents();
+    TabDialogs::FromWebContents(web_contents)
+        ->ShowHungRendererDialog(content::WebContentsUnresponsiveState());
+  }
+
+  views::Widget* widget_;

[tapted, 2017/02/01 00:52:48]

unused?

[Bret, 2017/02/01 02:21:46]

Oops yeah. Removed.

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(HungRendererDialogViewBrowserTest);
+};
+
+class HungRendererDialogViewBrowserTestMd
+    : public HungRendererDialogViewBrowserTest {
+ public:
+  HungRendererDialogViewBrowserTestMd() {}
+
+  // content::BrowserTestBase:
+  void SetUpCommandLine(base::CommandLine* command_line) override {

[tapted, 2017/02/01 00:52:48]

I think this can be merged into the above test harness (unless we want another
test case for non-MD, but I'd probably skip that). (the approach here is useful
when there's an existing browser_test harness that's being adapted, but that's
not the case for this one)

[Bret, 2017/02/01 02:21:46]

Done.

+    command_line->AppendSwitch(switches::kExtendMdToSecondaryUi);
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(HungRendererDialogViewBrowserTestMd);
+};
+
+IN_PROC_BROWSER_TEST_F(HungRendererDialogViewBrowserTestMd,

[tapted, 2017/02/01 00:52:48]

nit: add a comment (I try to ensure every TEST_F has a comment above it
describing why the test exists). For these, I've been doing things like

// Calls ShowDialog("default"). Interactive when run via browser_tests
--gtest_filter=BrowserDialogTest.Invoke --interactive
--dialog=HungRendererDialogViewBrowserTest.InvokeDialog_default.

[Bret, 2017/02/01 02:21:46]

I don't like the idea of baking the invocation into the comment. How's this?

+                       InvokeDialog_default) {
+  RunDialog();
+}