Extend front_end API to accept patch files

Extend front_end API to accept patch files

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/a37b3829ec009b2361167c52b1a8a7e918f526c7

[Siggi Cherem (dart-lang), 2017-01-27 21:52:45]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-01-27 21:55:51]

https://codereview.chromium.org/2660553003/diff/20001/pkg/front_end/lib/kerne...
File pkg/front_end/lib/kernel_generator.dart (right):

https://codereview.chromium.org/2660553003/diff/20001/pkg/front_end/lib/kerne...
pkg/front_end/lib/kernel_generator.dart:49:
loader.loadLibrary(Uri.parse('dart:_builtin'));
this came up in the context of my other CL where I'm running the
kernel-service.dart through the frontend. 

I thought we were going to need to pass in a list of core libraries to load, but
I'm not certain at this point that it will be needed, so I opted for this
temporary exception until we figure that out.

https://codereview.chromium.org/2660553003/diff/20001/pkg/front_end/lib/kerne...
pkg/front_end/lib/kernel_generator.dart:150:
options.fileSystem.context.fromUri(options.sdkRoot.resolveUri(patch));
you'll see in the other CL that this is not used yet, I'm using only absolute
URIs, the reason is that none of the VM patches are shipped with the SDK today.
That needs to change in the future.

[Siggi Cherem (dart-lang), 2017-01-27 21:56:38]

+danrubel +ahe - FYI, here is a change to the frontend API to make it possible
to use patch files.

[Paul Berry, 2017-01-27 22:49:19]

lgtm

https://codereview.chromium.org/2660553003/diff/20001/pkg/front_end/lib/kerne...
File pkg/front_end/lib/kernel_generator.dart (right):

https://codereview.chromium.org/2660553003/diff/20001/pkg/front_end/lib/kerne...
pkg/front_end/lib/kernel_generator.dart:150:
options.fileSystem.context.fromUri(options.sdkRoot.resolveUri(patch));
Add a TODO comment here: we should switch this code over to using
ProcessedOptions so that we can resolve the URIs correctly even if the SDK root
is not directly specified (in some cases it will be automatically inferred).

You can assign the TODO to me if you want.

[Siggi Cherem (dart-lang), 2017-01-27 23:00:19]

thanks!

https://codereview.chromium.org/2660553003/diff/20001/pkg/front_end/lib/kerne...
File pkg/front_end/lib/kernel_generator.dart (right):

https://codereview.chromium.org/2660553003/diff/20001/pkg/front_end/lib/kerne...
pkg/front_end/lib/kernel_generator.dart:150:
options.fileSystem.context.fromUri(options.sdkRoot.resolveUri(patch));
On 2017/01/27 22:49:19, Paul Berry wrote:
> Add a TODO comment here: we should switch this code over to using
> ProcessedOptions so that we can resolve the URIs correctly even if the SDK
root
> is not directly specified (in some cases it will be automatically inferred).
> 
> You can assign the TODO to me if you want.

Done.

[Siggi Cherem (dart-lang), 2017-01-27 23:00:43]

Description was changed from

==========
Extend front_end API to accept patch files

R=paulberry@google.com
==========

to

==========
Extend front_end API to accept patch files

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a37b3829ec009b2361167c52b1a8a7e918f526c7
==========

[Siggi Cherem (dart-lang), 2017-01-27 23:00:43]

Committed patchset #2 (id:40001) manually as
a37b3829ec009b2361167c52b1a8a7e918f526c7 (presubmit successful).