chrome/browser/ui/website_settings/permission_bubble_manager.h - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/metro_pin_tab_helper_win.cc ('k') | chrome/browser/ui/website_settings/permission_bubble_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_bubble_manager.h

diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.h b/chrome/browser/ui/website_settings/permission_bubble_manager.h

index bbf8e85fd4296287312056e52b024a085514cd39..231d5ddf59cc3e996b9e6fa89fe51d54eafbc6af 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_manager.h

+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.h

@@ -67,7 +67,7 @@ class PermissionBubbleManager

// TODO(leng): Finalize policy for permission requests with iFrames.

// DocumentLoadedInFrame() might be needed as well.

- virtual void DocumentOnLoadCompletedInMainFrame(int32 page_id) OVERRIDE;

+ virtual void DocumentOnLoadCompletedInMainFrame() OVERRIDE;

// If a page on which permissions requests are pending is navigated,

// they will be finalized as if canceled by the user.

« no previous file with comments | « chrome/browser/ui/metro_pin_tab_helper_win.cc ('k') | chrome/browser/ui/website_settings/permission_bubble_manager.cc » ('j') | no next file with comments »