chrome/browser/ui/website_settings/permission_bubble_manager.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager.h ('k') | chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc

diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc

index 18072e1631926dd5dbebf3063537893be1d4a6ca..6593e3842858a62eb07fd3a43d98b1b35708c189 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc

+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc

@@ -120,8 +120,7 @@ void PermissionBubbleManager::SetView(PermissionBubbleView* view) {

ShowBubble();

}

-void PermissionBubbleManager::DocumentOnLoadCompletedInMainFrame(

- int32 page_id) {

+void PermissionBubbleManager::DocumentOnLoadCompletedInMainFrame() {

request_url_has_loaded_ = true;

// This is scheduled because while all calls to the browser have been

// issued at DOMContentLoaded, they may be bouncing around in scheduled