chrome/browser/extensions/favicon_downloader.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/favicon_downloader.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/favicon_downloader.cc

diff --git a/chrome/browser/extensions/favicon_downloader.cc b/chrome/browser/extensions/favicon_downloader.cc

index b518a3213ea6eb9f8f656580848998383192b6eb..4237eb7f1466a836b48d712952d3a7d37fe1bc28 100644

--- a/chrome/browser/extensions/favicon_downloader.cc

+++ b/chrome/browser/extensions/favicon_downloader.cc

@@ -112,7 +112,6 @@ void FaviconDownloader::DidNavigateMainFrame(

}

void FaviconDownloader::DidUpdateFaviconURL(

- int32 page_id,

const std::vector<content::FaviconURL>& candidates) {

// Only consider the first candidates we are given. This prevents pages that

// change their favicon from spamming us.

« no previous file with comments | « chrome/browser/extensions/favicon_downloader.h ('k') | chrome/browser/extensions/favicon_downloader_unittest.cc » ('j') | no next file with comments »