Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: content/renderer/render_view_impl.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 7290a4b5a2f5be0ea43e7b8b71aaf13579c7d0da..9a9d7f6f3f450a373e4a6ad471ce141eb197b8da 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2323,10 +2323,8 @@ void RenderViewImpl::didChangeIcon(WebLocalFrame* frame,
}
void RenderViewImpl::didHandleOnloadEvents(WebLocalFrame* frame) {
- if (webview()->mainFrame() == frame) {
- Send(new ViewHostMsg_DocumentOnLoadCompletedInMainFrame(routing_id_,
- page_id_));
- }
+ if (webview()->mainFrame() == frame)
+ Send(new ViewHostMsg_DocumentOnLoadCompletedInMainFrame(routing_id_));
}
void RenderViewImpl::didUpdateCurrentHistoryItem(WebLocalFrame* frame) {
@@ -3345,8 +3343,7 @@ void RenderViewImpl::DidFlushPaint() {
if (data->did_first_visually_non_empty_layout() &&
!data->did_first_visually_non_empty_paint()) {
data->set_did_first_visually_non_empty_paint(true);
- Send(new ViewHostMsg_DidFirstVisuallyNonEmptyPaint(routing_id_,
- page_id_));
+ Send(new ViewHostMsg_DidFirstVisuallyNonEmptyPaint(routing_id_));
}
// TODO(jar): The following code should all be inside a method, probably in
@@ -4313,7 +4310,7 @@ void RenderViewImpl::DidCommitCompositorFrame() {
void RenderViewImpl::SendUpdateFaviconURL(const std::vector<FaviconURL>& urls) {
if (!urls.empty())
- Send(new ViewHostMsg_UpdateFaviconURL(routing_id_, page_id_, urls));
+ Send(new ViewHostMsg_UpdateFaviconURL(routing_id_, urls));
}
void RenderViewImpl::DidStopLoadingIcons() {

Powered by Google App Engine
This is Rietveld 408576698