Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/view_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index fea916e68d920a2ffc7b2c26ea8388443caaedcf..a6caac31d9897c8dfd95d23efab88958e7d3b143 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2803,10 +2803,9 @@ void WebContentsImpl::OnDidDownloadImage(
}
void WebContentsImpl::OnUpdateFaviconURL(
- int32 page_id,
const std::vector<FaviconURL>& candidates) {
FOR_EACH_OBSERVER(WebContentsObserver, observers_,
- DidUpdateFaviconURL(page_id, candidates));
+ DidUpdateFaviconURL(candidates));
}
void WebContentsImpl::OnMediaPlayingNotification(int64 player_cookie,
@@ -2842,9 +2841,9 @@ void WebContentsImpl::OnMediaPausedNotification(int64 player_cookie) {
#endif // !defined(OS_CHROMEOS)
}
-void WebContentsImpl::OnFirstVisuallyNonEmptyPaint(int32 page_id) {
+void WebContentsImpl::OnFirstVisuallyNonEmptyPaint() {
FOR_EACH_OBSERVER(WebContentsObserver, observers_,
- DidFirstVisuallyNonEmptyPaint(page_id));
+ DidFirstVisuallyNonEmptyPaint());
}
void WebContentsImpl::DidChangeVisibleSSLState() {
@@ -3453,16 +3452,15 @@ void WebContentsImpl::DocumentAvailableInMainFrame(
}
void WebContentsImpl::DocumentOnLoadCompletedInMainFrame(
- RenderViewHost* render_view_host,
- int32 page_id) {
+ RenderViewHost* render_view_host) {
FOR_EACH_OBSERVER(WebContentsObserver, observers_,
- DocumentOnLoadCompletedInMainFrame(page_id));
+ DocumentOnLoadCompletedInMainFrame());
// TODO(avi): Remove. http://crbug.com/170921
NotificationService::current()->Notify(
NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
Source<WebContents>(this),
- Details<int>(&page_id));
Charlie Reis 2014/05/02 22:33:22 I checked on code search and couldn't find anyone
+ NotificationService::NoDetails());
}
void WebContentsImpl::RouteCloseEvent(RenderViewHost* rvh) {
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/view_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698