content/browser/renderer_host/render_view_host_impl.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/web_contents/aura/overscroll_navigation_overlay.h » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 516fc11dfbe9876c057212d060d21fbe75edf333..e35a27b12c18660d1b3c02131431312d6f43f00a 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -1238,9 +1238,8 @@ void RenderViewHostImpl::OnDocumentAvailableInMainFrame() {

delegate_->DocumentAvailableInMainFrame(this);

}

-void RenderViewHostImpl::OnDocumentOnLoadCompletedInMainFrame(

- int32 page_id) {

- delegate_->DocumentOnLoadCompletedInMainFrame(this, page_id);

+void RenderViewHostImpl::OnDocumentOnLoadCompletedInMainFrame() {

+ delegate_->DocumentOnLoadCompletedInMainFrame(this);

}

void RenderViewHostImpl::OnToggleFullscreen(bool enter_fullscreen) {