Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 virtual void UpdateEncoding(RenderViewHost* render_view_host, 367 virtual void UpdateEncoding(RenderViewHost* render_view_host,
368 const std::string& encoding) OVERRIDE; 368 const std::string& encoding) OVERRIDE;
369 virtual void UpdateTargetURL(int32 page_id, const GURL& url) OVERRIDE; 369 virtual void UpdateTargetURL(int32 page_id, const GURL& url) OVERRIDE;
370 virtual void Close(RenderViewHost* render_view_host) OVERRIDE; 370 virtual void Close(RenderViewHost* render_view_host) OVERRIDE;
371 virtual void RequestMove(const gfx::Rect& new_bounds) OVERRIDE; 371 virtual void RequestMove(const gfx::Rect& new_bounds) OVERRIDE;
372 virtual void DidCancelLoading() OVERRIDE; 372 virtual void DidCancelLoading() OVERRIDE;
373 virtual void DidChangeLoadProgress(double progress) OVERRIDE; 373 virtual void DidChangeLoadProgress(double progress) OVERRIDE;
374 virtual void DocumentAvailableInMainFrame( 374 virtual void DocumentAvailableInMainFrame(
375 RenderViewHost* render_view_host) OVERRIDE; 375 RenderViewHost* render_view_host) OVERRIDE;
376 virtual void DocumentOnLoadCompletedInMainFrame( 376 virtual void DocumentOnLoadCompletedInMainFrame(
377 RenderViewHost* render_view_host, 377 RenderViewHost* render_view_host) OVERRIDE;
378 int32 page_id) OVERRIDE;
379 virtual void RouteCloseEvent(RenderViewHost* rvh) OVERRIDE; 378 virtual void RouteCloseEvent(RenderViewHost* rvh) OVERRIDE;
380 virtual void RouteMessageEvent( 379 virtual void RouteMessageEvent(
381 RenderViewHost* rvh, 380 RenderViewHost* rvh,
382 const ViewMsg_PostMessage_Params& params) OVERRIDE; 381 const ViewMsg_PostMessage_Params& params) OVERRIDE;
383 virtual bool AddMessageToConsole(int32 level, 382 virtual bool AddMessageToConsole(int32 level,
384 const base::string16& message, 383 const base::string16& message,
385 int32 line_no, 384 int32 line_no,
386 const base::string16& source_id) OVERRIDE; 385 const base::string16& source_id) OVERRIDE;
387 virtual RendererPreferences GetRendererPrefs( 386 virtual RendererPreferences GetRendererPrefs(
388 BrowserContext* browser_context) const OVERRIDE; 387 BrowserContext* browser_context) const OVERRIDE;
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 const base::ListValue& args); 739 const base::ListValue& args);
741 void OnRequestPpapiBrokerPermission(int routing_id, 740 void OnRequestPpapiBrokerPermission(int routing_id,
742 const GURL& url, 741 const GURL& url,
743 const base::FilePath& plugin_path); 742 const base::FilePath& plugin_path);
744 void OnBrowserPluginMessage(const IPC::Message& message); 743 void OnBrowserPluginMessage(const IPC::Message& message);
745 void OnDidDownloadImage(int id, 744 void OnDidDownloadImage(int id,
746 int http_status_code, 745 int http_status_code,
747 const GURL& image_url, 746 const GURL& image_url,
748 const std::vector<SkBitmap>& bitmaps, 747 const std::vector<SkBitmap>& bitmaps,
749 const std::vector<gfx::Size>& original_bitmap_sizes); 748 const std::vector<gfx::Size>& original_bitmap_sizes);
750 void OnUpdateFaviconURL(int32 page_id, 749 void OnUpdateFaviconURL(const std::vector<FaviconURL>& candidates);
751 const std::vector<FaviconURL>& candidates); 750 void OnFirstVisuallyNonEmptyPaint();
752 void OnFirstVisuallyNonEmptyPaint(int32 page_id);
753 void OnMediaPlayingNotification(int64 player_cookie, 751 void OnMediaPlayingNotification(int64 player_cookie,
754 bool has_video, 752 bool has_video,
755 bool has_audio); 753 bool has_audio);
756 void OnMediaPausedNotification(int64 player_cookie); 754 void OnMediaPausedNotification(int64 player_cookie);
757 void OnShowValidationMessage(const gfx::Rect& anchor_in_root_view, 755 void OnShowValidationMessage(const gfx::Rect& anchor_in_root_view,
758 const base::string16& main_text, 756 const base::string16& main_text,
759 const base::string16& sub_text); 757 const base::string16& sub_text);
760 void OnHideValidationMessage(); 758 void OnHideValidationMessage();
761 void OnMoveValidationMessage(const gfx::Rect& anchor_in_root_view); 759 void OnMoveValidationMessage(const gfx::Rect& anchor_in_root_view);
762 760
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
1097 1095
1098 // Whether the last JavaScript dialog shown was suppressed. Used for testing. 1096 // Whether the last JavaScript dialog shown was suppressed. Used for testing.
1099 bool last_dialog_suppressed_; 1097 bool last_dialog_suppressed_;
1100 1098
1101 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl); 1099 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
1102 }; 1100 };
1103 1101
1104 } // namespace content 1102 } // namespace content
1105 1103
1106 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1104 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698