Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: net/base/net_string_util_icu.cc

Issue 266053002: Implement alternative string conversion functions in net/ on Android, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/net_string_util_icu.cc
diff --git a/net/base/net_string_util_icu.cc b/net/base/net_string_util_icu.cc
index f8a1ce7544e4c184729de03834b661a85cfcf120..fea7dcadfb972e4b6318ea0ff61f27ef6ec2cee8 100644
--- a/net/base/net_string_util_icu.cc
+++ b/net/base/net_string_util_icu.cc
@@ -11,6 +11,8 @@
namespace net {
+const char* const kLatin1 = base::kCodepageLatin1;
+
bool ConvertToUtf8(const std::string& text, const char* charset,
std::string* output) {
output->clear();
@@ -43,20 +45,18 @@ bool ConvertToUtf8AndNormalize(const std::string& text, const char* charset,
return base::ConvertToUtf8AndNormalize(text, charset, output);
}
-bool ConvertLatin1ToUtf8AndNormalize(const std::string& text,
- std::string* output) {
- return net::ConvertToUtf8AndNormalize(text, base::kCodepageLatin1, output);
-}
-
bool ConvertToUTF16(const std::string& text, const char* charset,
base::string16* output) {
return base::CodepageToUTF16(text, charset,
base::OnStringConversionError::FAIL, output);
}
-bool ConvertLatin1ToUTF16(const std::string& text, base::string16* output) {
- return base::CodepageToUTF16(text, base::kCodepageLatin1,
- base::OnStringConversionError::FAIL, output);
+void ConvertToUTF16WithSubstitutions(const std::string& text,
+ const char* charset,
+ base::string16* output) {
+ return base::CodepageToUTF16(bytes, charset,
+ base::OnStringConversionError::SUBSTITUTE,
+ output);
}
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698