Implement alternative string conversion functions in net/ on Android,

Implement alternative string conversion functions in net/ on Android,
using Java conversion functions.  This is part of making it possible
to build net/ without ICU, to get binary size down when building net/
as a library

BUG=362608
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269595

[mmenke, 2014-05-05 15:07:06]

This depends on USE_ICU_ALTERNATIVES from the CL currently out for review. 
Could get started on reviewing it now, or wait for that CL to land.

[mef, 2014-05-06 15:40:57]

https://codereview.chromium.org/266053002/diff/1/net/DEPS
File net/DEPS (right):

https://codereview.chromium.org/266053002/diff/1/net/DEPS#newcode47
net/DEPS:47: # Only use icu for string conversions.
is this comment still relevant?

https://codereview.chromium.org/266053002/diff/1/net/android/java/src/org/chr...
File net/android/java/src/org/chromium/net/NetStringUtil.java (right):

https://codereview.chromium.org/266053002/diff/1/net/android/java/src/org/chr...
net/android/java/src/org/chromium/net/NetStringUtil.java:31: ByteBuffer text,
I presume that |text| is array of char, but it is not clear.

https://codereview.chromium.org/266053002/diff/1/net/android/java/src/org/chr...
net/android/java/src/org/chromium/net/NetStringUtil.java:34: Charset charset =
Charset.forName(charset_name);
what happens if charset_name is invalid?

https://codereview.chromium.org/266053002/diff/1/net/android/java/src/org/chr...
net/android/java/src/org/chromium/net/NetStringUtil.java:73: Charset charset =
Charset.forName(charset_name);
check charset != null?

https://codereview.chromium.org/266053002/diff/1/net/base/net_string_util.h
File net/base/net_string_util.h (right):

https://codereview.chromium.org/266053002/diff/1/net/base/net_string_util.h#n...
net/base/net_string_util.h:17: extern const char* const kLatin1;
Should the name be more explicit, like |kCharsetLatin1|?

[mmenke, 2014-05-06 18:57:20]

Thanks for the feedback!

https://codereview.chromium.org/266053002/diff/1/net/DEPS
File net/DEPS (right):

https://codereview.chromium.org/266053002/diff/1/net/DEPS#newcode47
net/DEPS:47: # Only use icu for string conversions.
On 2014/05/06 15:40:58, mef wrote:
> is this comment still relevant?

Not really, removed.

https://codereview.chromium.org/266053002/diff/1/net/android/java/src/org/chr...
File net/android/java/src/org/chromium/net/NetStringUtil.java (right):

https://codereview.chromium.org/266053002/diff/1/net/android/java/src/org/chr...
net/android/java/src/org/chromium/net/NetStringUtil.java:31: ByteBuffer text,
On 2014/05/06 15:40:58, mef wrote:
> I presume that |text| is array of char, but it is not clear.

Done.

https://codereview.chromium.org/266053002/diff/1/net/android/java/src/org/chr...
net/android/java/src/org/chromium/net/NetStringUtil.java:34: Charset charset =
Charset.forName(charset_name);
On 2014/05/06 15:40:58, mef wrote:
> what happens if charset_name is invalid?

It throws an IllegalCharsetNameException or UnsupportedCharsetException,
depending on its mood.

https://codereview.chromium.org/266053002/diff/1/net/android/java/src/org/chr...
net/android/java/src/org/chromium/net/NetStringUtil.java:73: Charset charset =
Charset.forName(charset_name);
On 2014/05/06 15:40:58, mef wrote:
> check charset != null?

We get an IllegalArgumentException in that case, and catch it.

https://codereview.chromium.org/266053002/diff/1/net/base/net_string_util.h
File net/base/net_string_util.h (right):

https://codereview.chromium.org/266053002/diff/1/net/base/net_string_util.h#n...
net/base/net_string_util.h:17: extern const char* const kLatin1;
On 2014/05/06 15:40:58, mef wrote:
> Should the name be more explicit, like |kCharsetLatin1|?

Done.

[mmenke, 2014-05-08 16:40:49]

[+brettw]:  Please review the url/ changes.

mef:  Please re-review when you get a chance.

[mef, 2014-05-08 17:09:04]

lgtm

https://codereview.chromium.org/266053002/diff/290001/net/cert/x509_cert_type...
File net/cert/x509_cert_types_mac.cc (right):

https://codereview.chromium.org/266053002/diff/290001/net/cert/x509_cert_type...
net/cert/x509_cert_types_mac.cc:118: if (!ConvertToUTF16(DataToString(data),
kLatin1, &utf16))
Hmm, I think kLatin1 is now renamed...

[mmenke, 2014-05-08 18:58:42]

https://codereview.chromium.org/266053002/diff/290001/net/cert/x509_cert_type...
File net/cert/x509_cert_types_mac.cc (right):

https://codereview.chromium.org/266053002/diff/290001/net/cert/x509_cert_type...
net/cert/x509_cert_types_mac.cc:118: if (!ConvertToUTF16(DataToString(data),
kLatin1, &utf16))
On 2014/05/08 17:09:04, mef wrote:
> Hmm, I think kLatin1 is now renamed...

Fixed, thanks!  (Given the state of the tree, took a while to find a revision
that I could run through the trybots, and wasn't testing locally on Mac)

[mmenke, 2014-05-09 15:33:45]

On 2014/05/08 18:58:42, mmenke wrote:
>
https://codereview.chromium.org/266053002/diff/290001/net/cert/x509_cert_type...
> File net/cert/x509_cert_types_mac.cc (right):
> 
>
https://codereview.chromium.org/266053002/diff/290001/net/cert/x509_cert_type...
> net/cert/x509_cert_types_mac.cc:118: if (!ConvertToUTF16(DataToString(data),
> kLatin1, &utf16))
> On 2014/05/08 17:09:04, mef wrote:
> > Hmm, I think kLatin1 is now renamed...
> 
> Fixed, thanks!  (Given the state of the tree, took a while to find a revision
> that I could run through the trybots, and wasn't testing locally on Mac)

brettw:  I'll separate out the GN changes to another CL, and send that out
separately.

[mmenke, 2014-05-09 15:34:02]

On 2014/05/09 15:33:45, mmenke wrote:
> On 2014/05/08 18:58:42, mmenke wrote:
> >
>
https://codereview.chromium.org/266053002/diff/290001/net/cert/x509_cert_type...
> > File net/cert/x509_cert_types_mac.cc (right):
> > 
> >
>
https://codereview.chromium.org/266053002/diff/290001/net/cert/x509_cert_type...
> > net/cert/x509_cert_types_mac.cc:118: if (!ConvertToUTF16(DataToString(data),
> > kLatin1, &utf16))
> > On 2014/05/08 17:09:04, mef wrote:
> > > Hmm, I think kLatin1 is now renamed...
> > 
> > Fixed, thanks!  (Given the state of the tree, took a while to find a
revision
> > that I could run through the trybots, and wasn't testing locally on Mac)
> 
> brettw:  I'll separate out the GN changes to another CL, and send that out
> separately.

Erm:  In other words, no need to review this one.

[mmenke, 2014-05-09 15:49:45]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-05-09 15:53:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/266053002/390001

[commit-bot: I haz the power, 2014-05-10 18:32:50]

Change committed as 269595