third_party/WebKit/Source/platform/heap/Persistent.h - Issue 2660463003: CrossThreadPersistent should acquire a lock before assigning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Persistent.h

Issue 2660463003: CrossThreadPersistent should acquire a lock before assigning (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/Persistent.h

diff --git a/third_party/WebKit/Source/platform/heap/Persistent.h b/third_party/WebKit/Source/platform/heap/Persistent.h

index 3fe022c0d501394e5d665b62fd59cc5242a22f6e..cc370354ede3e5b2e3d458d898a578c104198c6d 100644

--- a/third_party/WebKit/Source/platform/heap/Persistent.h

+++ b/third_party/WebKit/Source/platform/heap/Persistent.h

@@ -175,6 +175,8 @@ class PersistentBase {

NO_SANITIZE_ADDRESS

void assign(T* ptr) {

if (crossThreadnessConfiguration == CrossThreadPersistentConfiguration) {

+ CrossThreadPersistentRegion::LockScope persistentLock(

+ ProcessHeap::crossThreadPersistentRegion());

releaseStore(

sof 2017/02/09 06:36:24 With the lock held, this could be a 'normal' store

reinterpret_cast<void* volatile*>(

const_cast<typename std::remove_const<T>::type**>(&m_raw)),

« no previous file with comments | « no previous file | no next file » | no next file with comments »