Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: runtime/bin/vmservice/client/deployed/web/index_devtools.html

Issue 266043004: Small cleanup to Code and Profiler pages (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/deployed/web/index_devtools.html
diff --git a/runtime/bin/vmservice/client/deployed/web/index_devtools.html b/runtime/bin/vmservice/client/deployed/web/index_devtools.html
index b88c7c09b2487b49b4e09a16ea288dda76689afc..104fd76a4560a72a86d58b424fe29239adead841 100644
--- a/runtime/bin/vmservice/client/deployed/web/index_devtools.html
+++ b/runtime/bin/vmservice/client/deployed/web/index_devtools.html
@@ -643,7 +643,12 @@
<template>
<link rel="stylesheet" href="packages/observatory/src/elements/css/shared.css">
<template if="{{ code.isDartCode }}">
- <a href="{{ url }}">{{ name }}</a>
+ <template if="{{ code.isOptimized }}">
+ <a href="{{ url }}">*{{ name }}</a>
+ </template>
+ <template if="{{ !code.isOptimized }}">
+ <a href="{{ url }}">{{ name }}</a>
+ </template>
</template>
<template if="{{ !code.isDartCode }}">
<span>{{ name }}</span>
@@ -706,14 +711,25 @@
<nav-refresh callback="{{ refresh }}"></nav-refresh>
</nav-bar>
<div class="content">
- <h1>Code for {{ code.name }}</h1>
+ <template if="{{ code.isDartCode &amp;&amp; code.isOptimized }}">
+ <h1>Optimized code for {{ code.name }}</h1>
+ </template>
+ <template if="{{ !(code.isDartCode &amp;&amp; code.isOptimized) }}">
+ <h1>Code for {{ code.name }}</h1>
+ </template>
<div class="memberList">
<div class="memberItem">
- <div class="memberName">kind</div>
+ <div class="memberName">Kind</div>
<div class="memberValue">{{code.kind}}</div>
</div>
+ <template if="{{ code.isDartCode }}">
+ <div class="memberItem">
+ <div class="memberName">Optimized</div>
+ <div class="memberValue">{{code.isOptimized}}</div>
+ </div>
+ </template>
<div class="memberItem">
- <div class="memberName">function</div>
+ <div class="memberName">Function</div>
<div class="memberValue">
<function-ref ref="{{code.function}}">
</function-ref>
@@ -1918,7 +1934,7 @@
<tbody>
<tr template="" repeat="{{row in tree.rows }}" style="{{}}">
<td on-click="{{toggleExpanded}}" class="{{ coloring(row) }}" style="{{ padding(row) }}">
- <span id="expand" style="cursor: pointer;">{{ row.expander }}</span>
+ <span id="expand" style="{{ row.expanderStyle }}">{{ row.expander }}</span>
<div style="position: relative;display: inline">
{{row.columns[0]}}
</div>

Powered by Google App Engine
This is Rietveld 408576698