third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp - Issue 2660393002: Use gfx::ColorSpace instead of SkColorSpace in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp

Issue 2660393002: Use gfx::ColorSpace instead of SkColorSpace in Blink (Closed)

Patch Set: Rebase (again) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp

diff --git a/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp b/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp

index e07812a9334aa888d754cbb06ad9c8501050604d..ea4f355a006542782324f846a31960955dc2fa03 100644

--- a/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp

+++ b/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp

@@ -301,7 +301,7 @@ TEST_F(ImageBitmapTest, ImageBitmapColorSpaceConversionHTMLImageElement) {

NOTREACHED();

break;

case ColorSpaceConversion::DEFAULT_NOT_COLOR_CORRECTED:

- colorSpace = ColorBehavior::globalTargetColorSpace();

+ colorSpace = ColorBehavior::globalTargetColorSpace().ToSkColorSpace();

colorFormat = colorFormat32;

break;

case ColorSpaceConversion::DEFAULT_COLOR_CORRECTED:

@@ -401,7 +401,7 @@ TEST_F(ImageBitmapTest, ImageBitmapColorSpaceConversionImageBitmap) {

NOTREACHED();

break;

case ColorSpaceConversion::DEFAULT_NOT_COLOR_CORRECTED:

- colorSpace = ColorBehavior::globalTargetColorSpace();

+ colorSpace = ColorBehavior::globalTargetColorSpace().ToSkColorSpace();

colorFormat = colorFormat32;

break;

case ColorSpaceConversion::DEFAULT_COLOR_CORRECTED:

@@ -492,7 +492,7 @@ TEST_F(ImageBitmapTest, ImageBitmapColorSpaceConversionStaticBitmapImage) {

NOTREACHED();

break;

case ColorSpaceConversion::DEFAULT_NOT_COLOR_CORRECTED:

- colorSpace = ColorBehavior::globalTargetColorSpace();

+ colorSpace = ColorBehavior::globalTargetColorSpace().ToSkColorSpace();

colorFormat = colorFormat32;

break;

case ColorSpaceConversion::DEFAULT_COLOR_CORRECTED: