third_party/WebKit/PRESUBMIT.py - Issue 2660393002: Use gfx::ColorSpace instead of SkColorSpace in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/PRESUBMIT.py

Issue 2660393002: Use gfx::ColorSpace instead of SkColorSpace in Blink (Closed)

Patch Set: Rebase (again) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/PRESUBMIT.py

diff --git a/third_party/WebKit/PRESUBMIT.py b/third_party/WebKit/PRESUBMIT.py

index fed225245184619fdb52e86b4db9746cbb280d18..517f5bca96d170ac3d5f47d42c6f722c70be5bf2 100644

--- a/third_party/WebKit/PRESUBMIT.py

+++ b/third_party/WebKit/PRESUBMIT.py

@@ -271,7 +271,7 @@ def _CheckForForbiddenNamespace(input_api, output_api):

# This list is not exhaustive, but covers likely ones.

chromium_namespaces = ["base", "cc", "content", "gfx", "net", "ui"]

chromium_forbidden_classes = ["scoped_refptr"]

- chromium_allowed_classes = ["gfx::CubicBezier"]

+ chromium_allowed_classes = ["gfx::ColorSpace", "gfx::CubicBezier"]

def source_file_filter(path):

return input_api.FilterSourceFile(path,

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('j') | no next file with comments »