| OLD | NEW |
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Blink. | 5 """Top-level presubmit script for Blink. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 264 if error: | 264 if error: |
| 265 results.append(output_api.PresubmitError('Found an invalid prefe
rence %s in expected result %s:%s' % (error.group(1), f, line_num))) | 265 results.append(output_api.PresubmitError('Found an invalid prefe
rence %s in expected result %s:%s' % (error.group(1), f, line_num))) |
| 266 return results | 266 return results |
| 267 | 267 |
| 268 | 268 |
| 269 def _CheckForForbiddenNamespace(input_api, output_api): | 269 def _CheckForForbiddenNamespace(input_api, output_api): |
| 270 """Checks that Blink uses Chromium namespaces only in permitted code.""" | 270 """Checks that Blink uses Chromium namespaces only in permitted code.""" |
| 271 # This list is not exhaustive, but covers likely ones. | 271 # This list is not exhaustive, but covers likely ones. |
| 272 chromium_namespaces = ["base", "cc", "content", "gfx", "net", "ui"] | 272 chromium_namespaces = ["base", "cc", "content", "gfx", "net", "ui"] |
| 273 chromium_forbidden_classes = ["scoped_refptr"] | 273 chromium_forbidden_classes = ["scoped_refptr"] |
| 274 chromium_allowed_classes = ["gfx::CubicBezier"] | 274 chromium_allowed_classes = ["gfx::ColorSpace", "gfx::CubicBezier"] |
| 275 | 275 |
| 276 def source_file_filter(path): | 276 def source_file_filter(path): |
| 277 return input_api.FilterSourceFile(path, | 277 return input_api.FilterSourceFile(path, |
| 278 white_list=[r'third_party/WebKit/Sourc
e/.*\.(h|cpp)$'], | 278 white_list=[r'third_party/WebKit/Sourc
e/.*\.(h|cpp)$'], |
| 279 black_list=[r'third_party/WebKit/Sourc
e/(platform|wtf|web)/']) | 279 black_list=[r'third_party/WebKit/Sourc
e/(platform|wtf|web)/']) |
| 280 | 280 |
| 281 comment_re = input_api.re.compile(r'^\s*//') | 281 comment_re = input_api.re.compile(r'^\s*//') |
| 282 result = [] | 282 result = [] |
| 283 for namespace in chromium_namespaces: | 283 for namespace in chromium_namespaces: |
| 284 namespace_re = input_api.re.compile(r'\b{0}::([A-Za-z_][A-Za-z0-9_]*)'.f
ormat(input_api.re.escape(namespace))) | 284 namespace_re = input_api.re.compile(r'\b{0}::([A-Za-z_][A-Za-z0-9_]*)'.f
ormat(input_api.re.escape(namespace))) |
| (...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 378 new_description = description | 378 new_description = description |
| 379 new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots) | 379 new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots) |
| 380 results.append(output_api.PresubmitNotifyResult( | 380 results.append(output_api.PresubmitNotifyResult( |
| 381 'Automatically added slimming-paint-v2 tests to run on CQ due to ' | 381 'Automatically added slimming-paint-v2 tests to run on CQ due to ' |
| 382 'changes in paint or compositing directories.')) | 382 'changes in paint or compositing directories.')) |
| 383 | 383 |
| 384 if new_description != description: | 384 if new_description != description: |
| 385 rietveld_obj.update_description(issue, new_description) | 385 rietveld_obj.update_description(issue, new_description) |
| 386 | 386 |
| 387 return results | 387 return results |
| OLD | NEW |