Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 2660383002: [MD settings] idle load basic and advanced pages (Closed)
Patch Set: review changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/basic_page/basic_page.js
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js
index bc14ed22a91762bfb3a84c109dc936b817fa8baf..d7ef1e9391588737929c0cccec4207b165bb7cae 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.js
+++ b/chrome/browser/resources/settings/basic_page/basic_page.js
@@ -29,6 +29,7 @@ Polymer({
advancedToggleExpanded: {
type: Boolean,
notify: true,
+ observer: 'advancedToggleExpandedChanged_',
},
/**
@@ -101,7 +102,7 @@ Polymer({
if (this.pageVisibility.advancedSettings !== false) {
assert(whenSearchDone === settings.getSearchManager().search(
- query, assert(this.$$('#advancedPage'))));
+ query, assert(this.$.advancedPageTemplate.get())));
}
return whenSearchDone;
@@ -131,6 +132,15 @@ Polymer({
},
/**
+ * Inform the idle render code that the advanced page to load.
dpapad 2017/01/31 23:10:13 Syntax is confusing, probably something is missing
dschuyler 2017/01/31 23:53:03 Done.
+ * @private
+ */
+ advancedToggleExpandedChanged_: function() {
+ if (this.advancedToggleExpanded)
+ this.$.advancedPageTemplate.get();
+ },
+
+ /**
* @param {boolean} inSearchMode
* @param {boolean} hasExpandedSection
* @return {boolean}

Powered by Google App Engine
This is Rietveld 408576698