chrome/browser/resources/settings/controls/settings_idle_render.html - Issue 2660383002: [MD settings] idle load basic and advanced pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/controls/settings_idle_render.html

Issue 2660383002: [MD settings] idle load basic and advanced pages (Closed)

Patch Set: review changes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2

	3 <script src="settings_idle_render.js"></script>
	dpapad 2017/02/01 00:30:04 controls/ folder is currently used for form elemen controls/ folder is currently used for form elements (radio button, dropdown, checkbox, slider). Does a <template> subclass belong in the same folder? Perhaps better to move it one level up under settings/ instead, along with other generic infrastructure elements (like direction_delegate.html)? dschuyler 2017/02/01 02:28:15 Hmm, well Dan said this earlier in this CL Show quoted text On 2017/02/01 00:30:04, dpapad wrote: > controls/ folder is currently used for form elements (radio button, dropdown, > checkbox, slider). Does a <template> subclass belong in the same folder? Perhaps > better to move it one level up under settings/ instead, along with other generic > infrastructure elements (like direction_delegate.html)? Hmm, well Dan said this earlier in this CL Show quoted text > so I vote this stays in settings until used elsewhere, just like the rest of our > custom elements in c/b/r/settings/controls/. I'm concerned about cluttering the parent directory. Maybe a new directory should be made for these things or maybe the name of the 'controls' directory should change to something else.
OLD	NEW