Issue 266036: Fix another race condition on worker process shutdown that results in use-aft...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266036: Fix another race condition on worker process shutdown that results in use-aft... (Closed)

Created:
11 years, 2 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix another race condition on worker process shutdown that results in use-after-free. Like 23018, this is happening because valgrind is slowing the worker thread shutdown enough that the backup terminate process code executes. BUG=24346 TEST=covered by valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28646

Patch Set 1 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -35 lines)			Patch
M	chrome/renderer/webworker_proxy.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/webworker_proxy.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/worker/nativewebworker_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/worker/nativewebworker_impl.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/worker/webworkerclient_proxy.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	2 chunks	+0 lines, -34 lines	0 comments	Download
M	webkit/api/public/WebWorker.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webworker_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webworker_impl.cc	View	7 chunks	+21 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_web_worker.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages