Issue 266035: Enable a lot of WorkerTest.WorkerFastLayoutTests and comment out...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266035: Enable a lot of WorkerTest.WorkerFastLayoutTests and comment out... (Closed)

Created:
11 years, 2 months ago by levin

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews_googlegroups.com, jam, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable a lot of WorkerTest.WorkerFastLayoutTests and comment out the only test that is failing. (The test is still being investigated but it is good to keep as much running as possible.) BUG=23391 TEST=Enabling tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28518

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	chrome/worker/worker_uitest.cc	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

11 years, 2 months ago (2009-10-09 00:49:55 UTC) #2

lgtm

http://codereview.chromium.org/266035/diff/1/2
File chrome/worker/worker_uitest.cc (right):

http://codereview.chromium.org/266035/diff/1/2#newcode50
Line 50: // WorkerFastLayoutTests failed on all platforms since r27553.
thi comment can be removed.

Expand Messages | Collapse Messages