Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2660333007: Enable NTPTilesInInstantService by default (Closed)

Created:
3 years, 10 months ago by Marc Treib
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable NTPTilesInInstantService by default BUG=514752

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/threat_details_unittest.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/search/instant_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
Marc Treib
The CQ bit was checked by treib@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-01 15:24:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660333007/1
3 years, 10 months ago (2017-02-01 15:24:52 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-01 15:51:29 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/381854)
3 years, 10 months ago (2017-02-01 15:51:30 UTC) #4
Marc Treib
The CQ bit was checked by treib@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-06 15:00:32 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660333007/20001
3 years, 10 months ago (2017-02-06 15:00:39 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-06 15:42:25 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 15:42:26 UTC) #8 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698