Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: lib/src/future_group.dart

Issue 2660333005: Change generic comment syntax to real generic syntax. (Closed)
Patch Set: Update version. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/delegate/stream_subscription.dart ('k') | lib/src/lazy_stream.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/future_group.dart
diff --git a/lib/src/future_group.dart b/lib/src/future_group.dart
index 114c13344c625d7fb515a509e30a05ed5febbbe7..9b85c2fcbdbebb64c828c2868b2ae800cd392663 100644
--- a/lib/src/future_group.dart
+++ b/lib/src/future_group.dart
@@ -67,19 +67,19 @@ class FutureGroup<T> implements Sink<Future<T>> {
_pending++;
task.then((value) {
- if (_completer.isCompleted) return;
+ if (_completer.isCompleted) return null;
_pending--;
_values[index] = value;
- if (_pending != 0) return;
+ if (_pending != 0) return null;
if (_onIdleController != null) _onIdleController.add(null);
- if (!_closed) return;
+ if (!_closed) return null;
if (_onIdleController != null) _onIdleController.close();
_completer.complete(_values);
}).catchError((error, stackTrace) {
- if (_completer.isCompleted) return;
+ if (_completer.isCompleted) return null;
_completer.completeError(error, stackTrace);
});
}
« no previous file with comments | « lib/src/delegate/stream_subscription.dart ('k') | lib/src/lazy_stream.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698