Split requestResource into request preparation and loading

third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
     Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
     rights reserved.
     Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 153 matching lines @@
                                      const String& charset,
                                      const ResourceFactory&);
   void storePerformanceTimingInitiatorInformation(Resource*);
   ResourceLoadPriority computeLoadPriority(
       Resource::Type,
       const ResourceRequest&,
       ResourcePriority::VisibilityStatus,
       FetchRequest::DeferOption = FetchRequest::NoDefer,
       bool forPreload = false);
 
+  struct PrepareRequestReturnValues {

[Charlie Harrison, 2017/01/30 22:02:58]

delete unused struct.

+    bool isStaticData{false};
+    bool shouldContinue{false};
+  };
+
+  Resource* prepareRequest(FetchRequest&,

[Charlie Harrison, 2017/01/30 22:02:58]

Please document this method. It is a bit strange for a method to be called
"prepareRequest" but return a Resource*, so I think a little explanation is
necessary.

+                           const ResourceFactory&,
+                           const SubstituteData&,
+                           unsigned long identifier,
+                           bool& isStaticData,
+                           bool& shouldContinue);
+
   Resource* resourceForStaticData(const FetchRequest&,
                                   const ResourceFactory&,
                                   const SubstituteData&);
   Resource* resourceForBlockedRequest(const FetchRequest&,
                                       const ResourceFactory&,
                                       ResourceRequestBlockedReason);
 
   // RevalidationPolicy enum values are used in UMAs https://crbug.com/579496.
   enum RevalidationPolicy { Use, Revalidate, Reload, Load };
   RevalidationPolicy determineRevalidationPolicy(Resource::Type,
@@ skipping 92 matching lines @@
   }
 
  private:
   Member<ResourceFetcher> m_loader;
   bool m_previousState;
 };
 
 }  // namespace blink
 
 #endif  // ResourceFetcher_h